Adaptive Path/CAM Operation

[sliptonic]

I will try building and testing this as soon as I can.
I really wish you'd consider developing this inside Path with an eye towards a full PR. It would make it much easier to get testers and eventually merged.

[kreso-t]

Hi sliptonic,
Thx, I don't see it as big effort to put it inside the Path.Area now, it's a matter of adding the adaptive.Xpp source and binding it to the Path.Area python module, maybe would require a little refactoring. Python side already uses all the base classes and concepts from the FreeCAD Path Mod/PathScripts ( PathOpGui.TaskPanelPage, PathOp.ObjectOp, ...) so no problem there.

If you would go for having this in the Path Workbench I can do a Pull Request on FreeCAD repo with this c++ part included into Path.Area and Python side into the Mod/Path/PathScripts and you can review it and make suggestions that would better fit the architecture and guidelines you may follow, but just to get it working inside the FreeCAD codebase should really not be a problem.

K.

[sliptonic]

I would definitely go for having this in Path but want more people testing and weighing in.

What about pybind11? Does that add a new dependency for FreeCAD? If so, that might require some discussion too.

[kkremitzki]

I would definitely go for having this in Path but want more people testing and weighing in.

What about pybind11? Does that add a new dependency for FreeCAD? If so, that might require some discussion too.

pybind11 is used for surface flattening in FreeCAD already: https://forum.freecadweb.org/viewtopic. ... &start=120 From wmayer:

The biggest problem with pybind11 is that it requires C++14 features and thus you must upgrade to at least VS2015 on Windows which for me is not an option (at the moment). Btw, the library should actually be called pybind14++.

[kreso-t]

pybind11 is used for surface flattening in FreeCAD already: https://forum.freecadweb.org/viewtopic. ... &start=120 From wmayer:

it's also already used by Path.Area (libarea/pyarea.cpp), there are also "boost" bindings there (libarea/PythonStuff.cpp). It should not be a problem to also add boost bindings for adaptive2d (python interface is simple, just two small classes and two enums).

[kreso-t]

I would definitely go for having this in Path but want more people testing and weighing in.

Ok, as I am not familiar with the process of testing and approving the FreeCAD PRs - would it help if I make these changes now in the forked FreeCAD code (i.e. in my github profile)? I could probably do that in the next few days.

[roivai]

Ok, as I am not familiar with the process of testing and approving the FreeCAD PRs - would it help if I make these changes now in the forked FreeCAD code (i.e. in my github profile)? I could probably do that in the next few days.

Yes - that's how it should be done. Fork the official FreeCAD repo on github and do the development on a branch there. Then you submit the pull request to merge the branch to the upstream FreeCAD repository. I found these instructions on the wiki: https://www.freecadweb.org/wiki/Source_code_management

That profile looks great!

[kreso-t]

Ok, as I am not familiar with the process of testing and approving the FreeCAD PRs - would it help if I make these changes now in the forked FreeCAD code (i.e. in my github profile)? I could probably do that in the next few days.

Yes - that's how it should be done. Fork the official FreeCAD repo on github and do the development on a branch there. Then you submit the pull request to merge the branch to the upstream FreeCAD repository. I found these instructions on the wiki: https://www.freecadweb.org/wiki/Source_code_management

That profile looks great!

Thx for the info, will do that

[kreso-t]

Thx for the info, will do that

But first need to do some more testing myself, I noticed an issue in some cases (for example when tool need to pass through very narrow area) that I need to fix.

[Kunda1]

ping

I wonder what @shaise thinks about this thread.