[Fixed]Win Build Failure: commit cee9f4f?

[sgrogan]

git commit cee9f4f
I think this https://github.com/FreeCAD/FreeCAD/comm ... 8b53221b41
is causing this

Code: Select all

Severity	Code	Description	Project	File	Line	Suppression State
Error	C1010	unexpected end of file while looking for precompiled header. Did you forget to add '#include "PreCompiled.h"' to your source?	Path	C:\Users\Chris\GitHub\FreeCAD\src\Mod\Path\App\PathSegmentWalker.cpp	360	

[mlampert]

My bad, I did add it to CMakeList.txt, what else is required for the Windows build?

EDIT: sorry, didn't read the error message correctly. I'll fix it, thanks for the ping.

[sgrogan]

EDIT: sorry, didn't read the error message correctly. I'll fix it, thanks for the ping.

It's hard to read. I should copy from the log not the error list.

Code: Select all

5>C:\Users\Chris\GitHub\FreeCAD\src\Mod\Path\App\PathSegmentWalker.cpp(360): fatal error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "PreCompiled.h"' to your source?

Thanks for the quick response.

[mlampert]

EDIT: sorry, didn't read the error message correctly. I'll fix it, thanks for the ping.

It's hard to read. I should copy from the log not the error list.

Code: Select all

5>C:\Users\Chris\GitHub\FreeCAD\src\Mod\Path\App\PathSegmentWalker.cpp(360): fatal error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "PreCompiled.h"' to your source?

Thanks for the quick response.

Interestingly I do include the precompiled header in the header file. That doesn't seem to count though - I've never quite understood how it works and what it does.

[sgrogan]

Interestingly I do include the precompiled header in the header file. That doesn't seem to count though - I've never quite understood how it works and what it does.

I think this is bad. I think the precompiled.h should never be included in a header, only in the .cpp file. I know wmayer has explained. I'll look for it.

EDIT:https://forum.freecadweb.org/viewtopic. ... 90#p226885

[mlampert]

I think this is bad. I think the precompiled.h should never be included in a header, only in the .cpp file. I know wmayer has explained. I'll look for it.

EDIT:https://forum.freecadweb.org/viewtopic. ... 90#p226885

Thanks for that - I guess I did exactly what should never, NEVER be done.

EDIT: unfortunately these days each update results in a full recompile, it'll be another hour or so until my build completes and I can submit the PR.

[mlampert]

PR-2576

[vocx]

PR-2576

Your pull request has a conflict because it seems Werner already added the precompile header into the proper .cpp file. See git commit 0aa0f1c. But it still needs to be removed from the header file. I suggest you rebase to correct the conflict.

[wmayer]

I fixed the build failure because of the missing export macro and pch in the source file. But I didn't realize the PCH inside the header and had no build failure because of this.

[mlampert]

I fixed the build failure because of the missing export macro and pch in the source file. But I didn't realize the PCH inside the header and had no build failure because of this.

Thanks, I didn't know about the export maccro and have made a note of that, and the PCH guidelines.