Dressup improvements (Deburr, LeadInOut)

[Wsk8]

Hello,
i noticed 2 things with dress ups.

1. If you disable a op with dressup, the dressup doesn't change its color. If you don't expand the dressup, it still looks active.

active.png (5.46 KiB) Viewed 2240 times

2. LeadInOut doesn't work with deburring. Creates strange paths.

deburr.png (119.53 KiB) Viewed 2240 times

BR

[dubstar-04]

Confirmed and reported:

https://tracker.freecadweb.org/view.php?id=4280

LeadIn.png (22.06 KiB) Viewed 2196 times

Thanks,

Dan

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19635 (Git)
Build type: Release
Branch: master
Hash: 757cfce10b87ca087d31ce38eb30f612bf55fcad
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)

[Kunda1]

https://tracker.freecadweb.org/view.php?id=4280

Hey dubstar-04 just a quick FYI that you can add bugs using the bug bbcode
it will automatically link to the bug without the need for the URL.

Code: Select all

[bug]4280[/bug]

becomes
issue #4280

[Wsk8]

I'm currently working on it. Already fixed the problem halfway.
Only one problem remains: the staring point.
Currently the operation takes the starting point of the op, but if it's a "bad" position like the corner in this example, it creates a wrong path.

BR

[Wsk8]

Submitted PR https://github.com/FreeCAD/FreeCAD/pull/3132

1. Fixed faulty path with LeadInOut Dressup for Deburr Op. First move of DeburrOp was a plunge (no X and Y coords specified). Dressup assumed entry point as 0,0.

2. LeadInOut Dressup calculated wrong direction, so i added "Side"-Attribut to OP, which is automatically assigned (but can be changed manual)

3. If the entry point of the deburr op is at an infelicitous point, path was also not correct. So i added the option "EntryPoint" to Deburr Op. Now you can choose the segment, where the op starts.

mfg

[RatonLaveur]

Is this applicable to other ops?

The segment selection for entry point is a good addition in my book. Will really start allowing these energy beam (AWJ, Laser, Plasma...) Paths to be used with FreeCAD more effectively.

[dubstar-04]

https://tracker.freecadweb.org/view.php?id=4280

Hey dubstar-04 just a quick FYI that you can add bugs using the bug bbcode
it will automatically link to the bug without the need for the URL.

Code: Select all

[bug]4280[/bug]

becomes
issue #4280

I forgot about that!

Thank you

[dubstar-04]

Submitted PR https://github.com/FreeCAD/FreeCAD/pull/3132

1. Fixed faulty path with LeadInOut Dressup for Deburr Op. First move of DeburrOp was a plunge (no X and Y coords specified). Dressup assumed entry point as 0,0.

2. LeadInOut Dressup calculated wrong direction, so i added "Side"-Attribut to OP, which is automatically assigned (but can be changed manual)

3. If the entry point of the deburr op is at an infelicitous point, path was also not correct. So i added the option "EntryPoint" to Deburr Op. Now you can choose the segment, where the op starts.

mfg

Thanks for this!!

While you are looking at this dress up would you be able to extend its functionality to work with the profile single edges operation?

It would benfit from having an 'extend' option that simply extended the start and end segments to allow cleaner lead in and lead out for single edge operations.

Thanks,

Dan

[Wsk8]

Is this applicable to other ops?

No, the deburr op depends only on engraving. For other ops it must be implemented separatly.

While you are looking at this dress up would you be able to extend its functionality to work with the profile single edges operation?

It would benfit from having an 'extend' option that simply extended the start and end segments to allow cleaner lead in and lead out for single edge operations.

I will see what i can do.

mfg

[Wsk8]

Added Extend LeadIn option:

extend.png (3.61 KiB) Viewed 1927 times

Arcs are now entered in correct angle:

extend_arc.png (3.82 KiB) Viewed 1927 times

br