Drilling Beyond the bottom of a hole

Here's the place for discussion related to CAM/CNC and the development of the Path module.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Wsk8
Posts: 182
Joined: Fri Dec 07, 2018 6:24 pm

Re: Drilling Beyond the bottom of a hole

Post by Wsk8 »

Yes, i will link you to the PR

br
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Drilling Beyond the bottom of a hole

Post by dubstar-04 »

Russ4262 wrote: Thu Apr 02, 2020 2:14 pm
Wsk8 wrote: Thu Apr 02, 2020 1:15 pm ping
Will you also fix line 444:

Code: Select all

        #xRotRad = 0.01

Thanks,
Russ
Its brilliant to see everyone working together like this!

great work everyone, now wash your hands.

Dan
chrisb
Veteran
Posts: 54207
Joined: Tue Mar 17, 2015 9:14 am

Re: Drilling Beyond the bottom of a hole

Post by chrisb »

roerich_64 wrote: Thu Apr 02, 2020 1:14 pm Yes.
I'm all with you as far as the proposed value and a warning is concerned. However, if a user decides to drill through workpiece, stock machine bed and if ehe so wishes his own foot he should be able to do so.

I have seen too often reasonable use cases which were not anticipated at all. And if the software decides for the user it is good in most cases, but the few remaining cases are usually a pain to solve.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Wsk8
Posts: 182
Joined: Fri Dec 07, 2018 6:24 pm

Re: Drilling Beyond the bottom of a hole

Post by Wsk8 »

Russ4262 wrote: Thu Apr 02, 2020 2:14 pm Will you also fix line 444:

Code: Select all

        #xRotRad = 0.01

It should read:

Code: Select all

        zRotRad = 0.01
The original was a typo, the `x` needed to be a `z`. It was commented out because it was a copy of the code two lines up.
Done
#3303
User avatar
roerich_64
Veteran
Posts: 1465
Joined: Thu May 21, 2015 7:00 pm
Location: Ostfriesland

Re: Drilling Beyond the bottom of a hole

Post by roerich_64 »

chrisb wrote: Thu Apr 02, 2020 3:52 pm
roerich_64 wrote: Thu Apr 02, 2020 1:14 pm Yes.
I'm all with you as far as the proposed value and a warning is concerned. However, if a user decides to drill through workpiece, stock machine bed and if ehe so wishes his own foot he should be able to do so.

I have seen too often reasonable use cases which were not anticipated at all. And if the software decides for the user it is good in most cases, but the few remaining cases are usually a pain to solve.
:lol:

I read the action here and to me it would be better i shut my mouth ;) :lol:

to all: nice to see the working together :)

Walter
Die Liebe wird siegen, denn sie ist unzerstörbar :) ;)
Post Reply