[fixed] new compiler warning in pathpyimp.cpp

[uwestoehr]

After git commit 8adadcf2c I get now this compilation warning:

Code: Select all

d:\freecadgit\src\mod\path\app\pathpyimp.cpp(198): warning C4715: 'Path::PathPy::getCycleTime': not all control paths return a value

Could you please have a look?

.

.

[dubstar-04]

After git commit 8adadcf2c I get now this compilation warning:

Could you please have a look?

This is a silly oversight in the python declaration:

Code: Select all

PyObject* PathPy::getCycleTime(PyObject * args)
{
    double hFeed, vFeed, hRapid, vRapid;
    if (PyArg_ParseTuple(args, "dddd", &hFeed, &vFeed, &hRapid, &vRapid)){
    	return PyFloat_FromDouble(getToolpathPtr()->getCycleTime(hFeed, vFeed, hRapid, vRapid));
    }
}

This needs to return 0 outside the if statement.

I will fix it later and make a pull request.

Sorry about that,

Dan

[dubstar-04]

PR Here: https://github.com/FreeCAD/FreeCAD/pull/3386

[uwestoehr]

PR Here: https://github.com/FreeCAD/FreeCAD/pull/3386

Confirmed fixed. Thanks.