Path 3DSurface loading error

Here's the place for discussion related to CAM/CNC and the development of the Path module.
User avatar
mpetrasinovic
Posts: 30
Joined: Sat Feb 22, 2020 10:19 am
Location: Belgrade, Serbia
Contact:

Path 3DSurface loading error

Postby mpetrasinovic » Sat May 16, 2020 10:53 am

I could not use 3DSurface because I get the following error on command activation. After that, surface selection those not work.

Code: Select all

Surfacing Select Mode
Traceback (most recent call last):
  File "C:\Program Files\FreeCAD_0.19.21068_x64_LP_12.1.2_PY3QT5-WinVS2015\Mod\Path\PathScripts\PathOpGui.py", line 104, in setEdit
    self.setupTaskPanel(TaskPanel(vobj.Object, self.deleteObjectsOnReject(), page, selection))
  File "C:\Program Files\FreeCAD_0.19.21068_x64_LP_12.1.2_PY3QT5-WinVS2015\Mod\Path\PathScripts\PathOpGui.py", line 115, in setupTaskPanel
    panel.setupUi()
  File "C:\Program Files\FreeCAD_0.19.21068_x64_LP_12.1.2_PY3QT5-WinVS2015\Mod\Path\PathScripts\PathOpGui.py", line 1058, in setupUi
    page.clearBase()
  File "C:\Program Files\FreeCAD_0.19.21068_x64_LP_12.1.2_PY3QT5-WinVS2015\Mod\Path\PathScripts\PathOpGui.py", line 543, in clearBase
    self.updatePanelVisibility('Operation', self.obj)
  File "C:\Program Files\FreeCAD_0.19.21068_x64_LP_12.1.2_PY3QT5-WinVS2015\Mod\Path\PathScripts\PathOpGui.py", line 404, in updatePanelVisibility
    page.updateVisibility(obj)
<class 'TypeError'>: updateVisibility() takes 1 positional argument but 2 were given
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.21068 (Git)
Build type: Release
Branch: master
Hash: 92fe9adebbff910c5a10d6230785a6b58935b677
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Serbian/Serbia (sr_RS)
Syres
Posts: 642
Joined: Thu Aug 09, 2018 11:14 am

Re: Path 3DSurface loading error

Postby Syres » Sun May 17, 2020 6:16 am

Confirmed using:

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.21097 (Git)
Build type: Release
Branch: master
Hash: a5ab09aa0941cc945e59848897b160f8cbfc0831
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)

I think line 404 of src\Mod\Path\PathScripts\PathOpGui.py should be changed from:

Code: Select all

                           page.updateVisibility(obj)
to:

Code: Select all

                            page.updateVisibility()
Give it a try, it appears to work correctly for me after the change.
Russ4262
Posts: 427
Joined: Sat Jun 30, 2018 3:22 pm

Re: Path 3DSurface loading error

Postby Russ4262 » Sun May 17, 2020 8:48 pm

My error. I will try to get a PR for this, soon.

Russ
Russ4262
Posts: 427
Joined: Sat Jun 30, 2018 3:22 pm

Re: Path 3DSurface loading error

Postby Russ4262 » Mon May 18, 2020 2:29 am

Evening,
The GitHub user, gwicke, has an active PR for this fix, [path] Small fix in PathOpGui #3477.

Russ
User avatar
mpetrasinovic
Posts: 30
Joined: Sat Feb 22, 2020 10:19 am
Location: Belgrade, Serbia
Contact:

Re: Path 3DSurface loading error

Postby mpetrasinovic » Mon May 18, 2020 7:33 am

That was fast!

Thank you very much.