Thanks.
...
I find the Pull Request template a bit confusing.Kunda1 wrote: ↑Wed Mar 24, 2021 11:40 am 3. Fill out the Pull Request template add a summary of your commit, link to the forum discussion and add an 'X' in between the square brackets for steps you have completed. The markdown format must be precise.Code: Select all
- [x] (correct) - [ x] (incorrect) - [x ] (incorrect) [x] (incorrect) -[x] (incorrect)
- [x] Your pull request is confined strictly to a single module.
This is easy.
- [ ] In case your pull request does more than just fixing small bugs,...
Can't say I did discuss the subject, except what you can read in this thread.
left it as it is.
- [ ] Your branch is [rebased](https://git-scm.com/docs/git-rebase) on latest master `git pull --rebase upstream master`
I have no idea what this is about. I got a copy from the FreeCAD master repository so I *assume* is is rebased to start with.
No further action done.
- [ ] All FreeCAD unit tests are confirmed...
I can't build FreeCAD, tried so about 12 months ago but never got it working, that includes the ability to run unit tests.
And I'm just adding a post processor script which I tested (extensively) with v0.17 and also used with v0.18 en v0.19
- [x] All commit messages are [well-written]...
I do hope so, but English is not my native language.
- [ ] Your pull request is well written and has a good description
No idea where I can put a pull request description. The form does not indicate an area for it, so... no?
- [ ] Commit messages include `issue #<id>` or `fixes #<id>` where...
No, it is not an issue fix.
And please remember to update the Wiki...
I would like to but I have no wiki access.
I did place my [x] boxes truthfully and then closed it with a comment.
Not sure if I *canceled* the pull request with this last action but it does give that impression to me.
...