BUG -Dressup Holding Tags on curves can cause inner curve of path

Here's the place for discussion related to CAM/CNC and the development of the Path module.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
MPC
Posts: 14
Joined: Tue Mar 02, 2021 10:41 am

BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by MPC »

Hi,

I have had this happen on a couple of jobs. If you apply holding tags to a curve such as a large hole the first time you do it the tags work correctly and the output is correct.

If you then change the job such as the feed rates and then re-output the G-Code the path for the tags ends up with an inner curve.

Please see screen shot below.

Holding Tags.png
Holding Tags.png (64.64 KiB) Viewed 1324 times

Kind Regards,

MPC.
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by GeneFC »

Please add your "About FreeCAD" info and a sample FCStd file.

Gene
MPC
Posts: 14
Joined: Tue Mar 02, 2021 10:41 am

Re: BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by MPC »

OS: Ubuntu 20.04.2 LTS (ubuntu:GNOME/ubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24291 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 0.19.2)
Hash: 7b5e18a0759de778b74d3a5c17eba9cb815035ac
Python version: 3.8.8
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United Kingdom (en_GB)


MPC
MPC
Posts: 14
Joined: Tue Mar 02, 2021 10:41 am

Re: BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by MPC »

Hi,

Unfortunately I corrected the original file.

I have tried to regenerate the problem with a different file.

While trying to get the BUG to happen again I tried the attached file. This file has a different problem. I built the pad from a sketch and set the path for the perimeter and central hols with tags okay.

I went into sketch and changed the hold diameter and now the tags remain dis-abled. I can not re-enable them.

MPC.
Attachments
Test.FCStd
Central holding tags cannot be enabled
(25.66 KiB) Downloaded 12 times
MPC
Posts: 14
Joined: Tue Mar 02, 2021 10:41 am

Re: BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by MPC »

Hi,

I managed to recreate the problem but I cannot think of any one event which caused the issue.

I did change the TAG values to whole numbers.


Inner curve problem.png
Inner curve problem.png (90.01 KiB) Viewed 1273 times

Inner Path Problem.png
Inner Path Problem.png (70.01 KiB) Viewed 1273 times


MPC.
Attachments
Test.FCStd
(30.93 KiB) Downloaded 18 times
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by GeneFC »

I tried your original "Test.FCStd" file, and I observed the following.

Recreating the tags was not a problem. Just use the provided option.

Capture.PNG
Capture.PNG (18.5 KiB) Viewed 1260 times

The tags were recreated, but unfortunately the strange shape problem arose. I tried with both the Version 0.19 release, and a very recent Version 0.20, with the same result.

Capture-19.PNG
Capture-19.PNG (20.92 KiB) Viewed 1260 times

There have been many issues with "reworks" when using the Path WB. The typical error seems to be that something internally is deleted, but the internal propagation of the deletion is not done. The error message is usually something like "None type object has no . . . . "

I noticed that you added a new sample file. Please use different names when you do that. It is very confusing for any would-be forum helpers when the same name is used for different files.

Gene
MPC
Posts: 14
Joined: Tue Mar 02, 2021 10:41 am

Re: BUG -Dressup Holding Tags on curves can cause inner curve of path

Post by MPC »

Thanks Gene,

I agree you can easily correct the issue.

Its something to watch out for because I have broken tools because the path with the inner curve tended to be the bottom path where the tool is deep into the part. This overloads the tool which breaks.

Is it worth adding this to the BUG list? If so how do you do it?

Take your point about file names!

Thanks,

Melvin.
Post Reply