Hi Dandubstar-04 wrote: ↑Sat Jul 10, 2021 3:35 pm updated the PR and except for drilling, I think all the reported issues have now been addressed.
PR Here:
https://github.com/dubstar-04/FeedsAndSpeeds/pull/11
I would appreciate some eyes on it if you get a chance.
Thanks,
Dan
Thanks for the updates, looking good. I can confirm user now gets warning if no document opened or job in document and tab order etc work well.
So while looking at these changes, I realised there were more situations to handle. A lot of below, is detailed 'fine tuning'. Great if can be updated, but also possibly can wait until more people look at and validate.
I will have a look at possible ways to handle the tool type (Endmill, drill, lathe), and also what options might be available to handle Tool material (HSS, Carbide), and also displaying imperial units, then discuss with you.
What if, while FS calc open, the User does things like:
- - closes document, then click Update TC in FS calc:
Code: Select all
08:46:36 Traceback (most recent call last): 08:46:36 File "C:\Users\spanner888\AppData\Roaming\FreeCAD\Mod\FandS_mine\PathFeedsAndSpeedsGui.py", line 113, in update_tool_controller 08:46:36 tc = self.get_tool_controller() 08:46:36 File "C:\Users\spanner888\AppData\Roaming\FreeCAD\Mod\FandS_mine\PathFeedsAndSpeedsGui.py", line 103, in get_tool_controller 08:46:36 jobs = FreeCAD.ActiveDocument.findObjects("Path::FeaturePython", "Job.*") 08:46:36 AttributeError: 'NoneType' object has no attribute 'findObjects'
- deletes job (& all it's TC) or just deletes one TC in a job, then try to update it from FS calc:
NO ERROR reported!! So nothing to indicate to user something has gone wrong. - Opens a TC to edit in Tasks toolControler edit. Then clicking Update TC, does works successfully to update any TC, but the TC open in edit pane does not update. So potential confusion and any changes made in TC edit, would overwrite changes from FS Calc.Guess this would require detecting if TC edit panel is open while FS calc opens to give error.
Below here acceptable as is? - changes TC in FreeCAD - then if click Update TC in FS calc, while overwrite any Feed, rpm changes just made. OK, user should realise.
- adds job/TC ...just not listed in FS calc, so user SHOULD notice and SHOULD realise what they have done.
- opens two or more FS calc. Currently can run more than one instance of the FS calc. Is this an issue? I can think of possible user confusion, but otherwise all ok?
- Closes, then reopens document, while FS calc left open? Then FS calc click Update TC, does works successfully. Situation is unusual and potentially confusing, but no error, so suggest leave behaviour as is.
I also had a closer look at behaviour of the FS calc input fields:
- Tool section: Tool diameter and Flutes, suggest these be disabled from editing. Especially as user might think these changes sent back to FC toolBit. I also noticed that changing Flute does update FS calc outputs, but changing Tool dia does not. Disabling these inputs would address all these.
Changing tool material from HSS to Carbide, does change outputs and of course needs to be left active, not disabled. - Feed section: All fields trigger updated FS calcs, ie as expected.
- Speed section: Selecting a material does update the Surface Speed, but no outputs change. I think the Power output should update.
Changing the RPM (override) field does update the outputs as expected.
Surface speed input accepts alpha characters as well.
Adding surface speed units - would reduce some user confusion.
Same for spindle speed, except that rpm is not a FC unit or property. So I was looking into PropertyQuantity to create an RPM unit https://forum.freecadweb.org/viewtopic.php?f=10&t=47992
But then found that rpm is apparently NOT a unit - see https://en.wikipedia.org/wiki/Revolutions_per_minute
So just suggest adding next to label to say "Spindle speed: (RPM)".
Similarly Chipload should be labelled as Chipload (mm/tooth)
Looks like one outcome of current inputs that use FC properties, is that these fields have a green tick, once value & units correctly entered, which is OK. But the fields without units have double arrows (spinboxes?). This is just minor inconsistency, probably not easy to change or even worthwile changing.
At some point need a version number in ui
At some point someone will want Imperial units....maybe could just use users FC preference, but also requires FS calc UI to change default units.