[PR#3775] Add Wire Orders property to Part Design Loft

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
User avatar
uwestoehr
Posts: 2174
Joined: Sun Jan 27, 2019 3:21 am

Re: [PR#3775] Add Wire Orders property to Part Design Loft

Postby uwestoehr » Mon Aug 10, 2020 5:36 pm

TheMarkster wrote:
Sun Aug 09, 2020 11:42 pm
I have some working code, but I want to do some additional tweaking and testing. Here are a few screenshots:
Amazing!

If you have it ready, could you please attach your FC test file (the one from the screenshots) to play a bit with it?
TheMarkster
Posts: 2060
Joined: Thu Apr 05, 2018 1:53 am

Re: [PR#3775] Add Wire Orders property to Part Design Loft

Postby TheMarkster » Wed Aug 12, 2020 1:27 am

uwestoehr wrote:
Mon Aug 10, 2020 5:36 pm
TheMarkster wrote:
Sun Aug 09, 2020 11:42 pm
I have some working code, but I want to do some additional tweaking and testing. Here are a few screenshots:
Amazing!

If you have it ready, could you please attach your FC test file (the one from the screenshots) to play a bit with it?
I just pushed the latest version.

Here is the file from the screenshots:
loft_test.FCStd
(134.48 KiB) Downloaded 25 times
My FreeCAD video series on youtube: https://www.youtube.com/c/mwganson
User avatar
uwestoehr
Posts: 2174
Joined: Sun Jan 27, 2019 3:21 am

Re: [PR#3775] Add Wire Orders property to Part Design Loft

Postby uwestoehr » Fri Sep 18, 2020 3:40 pm

TheMarkster wrote:
Wed Aug 12, 2020 1:27 am
I just pushed the latest version.
Here is the file from the screenshots:
loft_test.FCStd
Many thanks!
I wanted to test it out but cannot apply your changes. I get a git error that there is no revision "e1bb0ef6e52". Could you please make a merge commit to your PR?
TheMarkster
Posts: 2060
Joined: Thu Apr 05, 2018 1:53 am

Re: [PR#3775] Add Wire Orders property to Part Design Loft

Postby TheMarkster » Fri Sep 18, 2020 4:01 pm

uwestoehr wrote:
Fri Sep 18, 2020 3:40 pm
TheMarkster wrote:
Wed Aug 12, 2020 1:27 am
I just pushed the latest version.
Here is the file from the screenshots:
loft_test.FCStd
Many thanks!
I wanted to test it out but cannot apply your changes. I get a git error that there is no revision "e1bb0ef6e52". Could you please make a merge commit to your PR?
I used the update branch button on github.
My FreeCAD video series on youtube: https://www.youtube.com/c/mwganson
User avatar
uwestoehr
Posts: 2174
Joined: Sun Jan 27, 2019 3:21 am

Re: [PR#3775] Add Wire Orders property to Part Design Loft

Postby uwestoehr » Mon Sep 21, 2020 9:31 am

TheMarkster wrote:
Fri Sep 18, 2020 4:01 pm
I used the update branch button on github.
OK, but since one cannot apply the PR, could you please make a merge commit or update the branch again?
User avatar
-alex-
Posts: 726
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: [PR#3775] Add Wire Orders property to Part Design Loft

Postby -alex- » Thu Jan 07, 2021 5:18 pm

TheMarkster wrote:
Sun Aug 09, 2020 11:42 pm
I have some working code, but I want to do some additional tweaking and testing. Here are a few screenshots:
Hi, any news about this great enhancement? :)