yorik wrote: ↑
Tue Jan 24, 2017 12:23 pm
I think there is no need anymore to post here when doing a pull request on github, unless you think there will/should be some discussion about it. Werner and me patrol the github repo often enough now...
It took me a while to figure out what the process for submitting PRs is, apparently the above quote is the latest info I could find, so I'm going to assume that this is the latest policy? I'm not entirely sure what that policy is though - just create a PR for simple changes, but when should a topic be made? Before creating the PR (and if so, should it be here or elsewhere)? Or after the PR is created (but can't discussion about PRs happen on github just as easy)?
In any case, maybe existing places with different policies should be updated? Here's the places I've seen so far:
- The first post of this thread.
- The description for the "Pull requests" subforum says "Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github", implying that all pullrequests must be discussed elsewhere first, and then *again* in this subforum.
- https://github.com/FreeCAD/FreeCAD/blob ... EMPLATE.md
- The README.md file in git does *not* have info, but I did look for it there, so might be worth maybe adding a link to the wiki there.
I can imagine that the wiki is a good place for the canonical policy, with other places linking to it?