Based on a conversation had here, I have begun updating/refactoring some of the code in src/Base/Console.h. My ultimate goal is to minimize/eliminate the need/use of macros in this file. As a first step, I have refactored the ConsoleObserver class.
I think the git commit message does a pretty good job explaining what changed, as well as the motivation. I am opening this thread because I'm not user if this is still the desired way to begin a conversation regarding pull requests (or if I should instead just rely on the commenting features on github itself).
PR2545 - Refactor and Rename ConsoleObserver
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 656
- Joined: Tue May 19, 2015 1:11 am