✓ [Merged] PR #3850 [Arch] PanelSheet

[vanuan]

Error when creating panel sheet:

Code: Select all

12:32:36  Running the Python command 'Arch_Panel_Sheet' failed:
Traceback (most recent call last):
  File "/workspace/build/Mod/Arch/ArchPanel.py", line 386, in Activated
    FreeCADGui.doCommand("Arch.makePanelSheet()")
  File "<string>", line 1, in <module>
  File "/workspace/build/Mod/Arch/ArchPanel.py", line 138, in makePanelSheet
    ViewProviderPanelSheet(sheet.ViewObject)
  File "/workspace/build/Mod/Arch/ArchPanel.py", line 1386, in __init__
    self.setProperties(self,vobj)

setProperties() takes 2 positional arguments but 3 were given

Fix: https://github.com/FreeCAD/FreeCAD/pull/3850

Found via mypy

[vanuan]

Was broken in this commit:
https://github.com/FreeCAD/FreeCAD/comm ... 94f81d3fb5

[vanuan]

Feature thread:
https://forum.freecadweb.org/viewtopic.php?f=9&t=19245

[vanuan]

Merged

[vocx]

Error when creating panel sheet:
...

I'd advise you to create threads about bugs and pull requests in the Draft/Arch/BIM subforum. There it will get more visibility by the community.

This pull request subforum is mostly used by those workbenches that don't have a dedicated forum to discuss things. Or for really big pull requests, like when App Link was merged. This subforum is something from the past, when the number of pull requests was very low. Now there are pull requests coming in all the time, so having a dedicated forum for them is not very useful in my opinion.