[PR #3873] Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
shermelin
Posts: 21
Joined: Tue Mar 24, 2020 12:48 pm

[PR #3873] Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Postby shermelin » Tue Sep 15, 2020 9:27 am

Hello,

I continue with projecting stuff in sketcher.

Here I implement the projection of circle of arcs, when the projection plane is orthogonal to the circle plane.

Hopefully, the rest will come soon ;)
Last edited by shermelin on Tue Sep 22, 2020 4:31 am, edited 1 time in total.
shermelin
Posts: 21
Joined: Tue Mar 24, 2020 12:48 pm

Re: Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Postby shermelin » Tue Sep 15, 2020 10:26 am

PR #3873
User avatar
uwestoehr
Posts: 2780
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: [PR #3873] Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Postby uwestoehr » Thu Sep 24, 2020 11:06 am

shermelin wrote: Tue Sep 15, 2020 9:27 am Here I implement the projection of circle of arcs, when the projection plane is orthogonal to the circle plane.
Many thanks!
Could you please describe how the new feature works, preferably with a simple test case? I will then try and document it in the Wiki.
shermelin
Posts: 21
Joined: Tue Mar 24, 2020 12:48 pm

Re: [PR #3873] Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Postby shermelin » Thu Sep 24, 2020 1:06 pm

@uwestoehr I just realize checking your reply that I forgot the screenshots!!!

Here they go, and should be self explanatory I guess (let me know if not).

The arcs arcs in the screenshots are always from the same sketch (plane XY). They are projected on XZ for the first 2 images and on a plane that is the rotation of XZ around Z by some angle I don't remember...
Attachments
projection-arcs.FCStd
(12.18 KiB) Downloaded 29 times
Capture d’écran_2020-09-15_09-04-32.png
Capture d’écran_2020-09-15_09-04-32.png (11.85 KiB) Viewed 1436 times
Capture d’écran_2020-09-15_09-04-10.png
Capture d’écran_2020-09-15_09-04-10.png (10.64 KiB) Viewed 1436 times
Capture d’écran_2020-09-15_09-03-55.png
Capture d’écran_2020-09-15_09-03-55.png (27.92 KiB) Viewed 1436 times
Capture d’écran_2020-05-10_08-30-04.png
Capture d’écran_2020-05-10_08-30-04.png (10.88 KiB) Viewed 1436 times
User avatar
saso
Posts: 1653
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: [PR #3873] Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Postby saso » Thu Sep 24, 2020 4:35 pm

shermelin wrote: Tue Sep 15, 2020 9:27 am Here I implement the projection of circle of arcs, when the projection plane is orthogonal to the circle plane.
Thanks shermelin for this improvements, I find them very nice since it is in a way a very core functionality. Is there something else? Arcs of elipse?
shermelin
Posts: 21
Joined: Tue Mar 24, 2020 12:48 pm

Re: [PR #3873] Sketcher: projection of arcs of circle (orthogonal to projection plane) (implemented)

Postby shermelin » Thu Sep 24, 2020 7:48 pm

[quote=saso post_id=433588 time=1600965326 user_id=3305]
Thanks shermelin for this improvements, I find them very nice since it is in a way a very core functionality. Is there something else? Arcs of elipse?
[/quote]

I need to check a bit more, but arcs of ellipses will be next, then most likely arcs of circle and ellipses in the general case. Then, I think we'll have most cases (nurbs seem already in).

I agree on the "core" part. I actually started this work while checking some scripts from path in which fairly convolved algorithms are used to project stuff. My idea, in the end, would be to move all that in a specific core functionnality, available to other worlbenches (base? A new 'geometry' WB?). But that's still some way ahead…