[ PR 3992 ] DXF import scale error

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

[ PR 3992 ] DXF import scale error

Post by Roy_043 »

FYI:
Roy_043 wrote: ↑Thu Oct 22, 2020 3:51 pm There is something wrong with the DXF. The MEASUREMENT is 0 (zero), which indicates imperial units. The legacy importer ignores this setting but the new importer does not. But obviously the new importer does not get it right. It uses a wrong factor (1/25.4 instead of 25.4)

PR:
https://github.com/FreeCAD/FreeCAD/pull/3992
Top
openBrain
Veteran
Posts: 9041
Joined: Fri Nov 09, 2018 5:38 pm
Contact:
Contact openBrain

Re: [ PR 3992 ] DXF import scale error

Post by openBrain »

There is a dedicated subforum for PRs. And it's not mandatory anymore to post them in the forum as it's easy to have a look in GitHub. ;)
Top
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ PR 3992 ] DXF import scale error

Post by Roy_043 »

OK, thanks.
Top
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: [ PR 3992 ] DXF import scale error

Post by Kunda1 »

Mod edit: moved to PR subforum
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Top
Post Reply

Return to “Pull Requests”