Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
abdullah wrote: ↑Sun Jun 20, 2021 5:23 pm
So you mean the new icon in the sketcher toolbar be made into a pseudo-toggle (similar to the construction geometry button or the reference constraints button). So when clicked without a selection, it functions as toggle, setting a status for the creation of the complex geometries that support this function. When clicked with selection, it just works as now. Is this what you mean?
Yes, exactly.
It is unlikely I will be able to code within the next couple of weeks. But I can take a look later on (or if you want to do it yourself I will look into the PR when I have some time).
I will probably also not have time soon. But when you could put it onto your list for the future, it would be nice.
abdullah wrote: ↑Sun Jun 20, 2021 5:23 pm
Thanks for providing these PRs. All are merged now.
Thanks.
I see now that I lost the changed slot icons while resolving a merge conflict. Can you therefore please also commit this PR: https://github.com/FreeCAD/FreeCAD/pull/4875
abdullah wrote: ↑Sun Jun 20, 2021 5:23 pm
Thanks for providing these PRs. All are merged now.
Thanks.
I see now that I lost the changed slot icons while resolving a merge conflict. Can you therefore please also commit this PR: https://github.com/FreeCAD/FreeCAD/pull/4875
uwestoehr wrote: ↑Sun Jun 20, 2021 9:59 pm
I will probably also not have time soon. But when you could put it onto your list for the future, it would be nice.
Remind me on the last week of July / first of August. I should have some holidays then...
Concerning 3D-printing, well, rounded rectangles are necessary also for milling since how do you mill a rectangular pocket? - There are always rounded edges in the result due to the milling tool.
A little bit offtopic: I wasn't aware of such a need regarding 3D printing. If I'm thinking about it, maybe that's because I usually round my corners to make them feel nicer. But I wouldn't have any problems while.printing them. Am I missing something here?
Regarding milling: Sometimes I create models which take those round inner corners into account. And sometimes I just add something to the drawing to make it clear what radius would be okay or something like that.
