Plot and Ship

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
Sanguinario_Joe
Posts: 60
Joined: Wed Jan 01, 2014 1:17 pm

Plot and Ship

Post by Sanguinario_Joe »

Plot and Ship modules have not been working for a long time, so I decided to fix them! (after some people pushed me to do that :D )

https://github.com/FreeCAD/FreeCAD/pull/4870

The code would really enjoy several improvements, but I really think is good enough to get the modules online again
user1234
Veteran
Posts: 3332
Joined: Mon Jul 11, 2016 5:08 pm

Re: Plot and Ship

Post by user1234 »

Ship as default on? I do not like that. I also think that the ship workbench is too specific, only my two cents.

Greetings
user1234
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: Plot and Ship

Post by carlopav »

Great work @Sanguinario_Joe! Good to have the workbenches fixed.
Following user1234 observation, which are the pros to you on having them inside the core FreeCAD rather than distributing them as external modules? I'm asking cause they seems 100% python
follow my experiments on BIM modelling for architecture design
Sanguinario_Joe
Posts: 60
Joined: Wed Jan 01, 2014 1:17 pm

Re: Plot and Ship

Post by Sanguinario_Joe »

Some years ago someone already asked that, and I already voted to move them out. But I came back and saw them inside the main source code tree, so I was thinking they finally decided to keep them.

@luzpaz added a note in the PR heading me to the right place. I am thus fixing the modules there, and editing the PR to remove any trace to Plot and Ship from the main repo.
Sanguinario_Joe
Posts: 60
Joined: Wed Jan 01, 2014 1:17 pm

Re: Plot and Ship

Post by Sanguinario_Joe »

Done, the correct PRs are submitted to https://github.com/FreeCAD/freecad.ship and https://github.com/FreeCAD/freecad.plot. Now the PR to the main source tree is actually removing those modules ;)
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: Plot and Ship

Post by carlopav »

great!
follow my experiments on BIM modelling for architecture design
Post Reply