Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
abdullah wrote: ↑Sun Sep 19, 2021 6:24 am
I will review the filter of the widget.
I may be one of the rare users, who had waited for more virtual spaces. If constraints can be shown in multiple virtual spaces, it could be used to have a virtual space for each type of constraint plus one for all, plus custom user spaces.
Just dreaming.
The extended filter is working now:
Screenshot_20210919_191610.png (77.2 KiB) Viewed 3047 times
I will evaluate the number of virtual spaces with the layer implementation. Maybe there is a way to make it intuitive.
abdullah wrote: ↑Fri Sep 17, 2021 11:05 pm
Looking at the PR functionality, there are some caveats:
- after one hides everything (by checking the checkbox), if one checks one of the individual checkboxes, the constraint is checked (in the list), shown in the 3D view, but the hide/show all listed constraints continues checked.
Thanks for having a look. Now I understand also @chennes request to use a button.
So in fact, yes, a button would make clear that the feature is designed to act only when the button is pressed. I will adapt the PR accordingly as soon as I find time.
Regarding your other statements it is not clear what you want to do. For me as the users, I only need a way to hide/show from a sketch either all datum constraints or even all constraints. Nothing more.
For sake of simplicity I would keep a Number of 2 Virtual Spaces but, anyway, I would like that they are not mutual exlusive.
I can not see a reason for which a constraint must be hidden in VS1 when it is unhidden in VS2.
In my opinion the visual settings of one Virtual Space should affect the visual settings of the other Virtual Space.
We know something similar to the concept of virtual spaces from other programs where they are called "Layers". The concept dorsn't seem to be really difficult to understand. I see two concepts of showing things: it is possible to show several layers at once and it is possible to have the same thing on different layers. These are not necessarily mutually exclusive.