Minor Improvement for Task Panel ResultShow

About the development of the FEM module/workbench.

Moderator: bernd

UR_
Posts: 1171
Joined: Tue Jan 03, 2017 8:42 pm

Re: Minor Improvement for Task Panel ResultShow

Postby UR_ » Mon Feb 17, 2020 6:11 pm

bernd wrote:
Wed Feb 12, 2020 10:49 pm
How about removing the Avg value?
Stats member "avg" removed from result object.

Histograms added


Source: https://github.com/UR-0/FreeCAD/commits ... result_obj

screenshot.gif
screenshot.gif (989.83 KiB) Viewed 151 times

Please have a look.

Migration of old result objects not yet implemented, so import a fresh calculated, ATM
HoWil
Posts: 914
Joined: Sun Jun 14, 2015 7:31 pm
Location: Austria

Re: Minor Improvement for Task Panel ResultShow

Postby HoWil » Mon Feb 17, 2020 6:40 pm

Nice!
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Minor Improvement for Task Panel ResultShow

Postby bernd » Tue Feb 18, 2020 4:37 am

cool addition :)

- is there a special reason for deleting the try here: https://github.com/UR-0/FreeCAD/commit/ ... 1R324-R327

- you forgot about the unit tests ... start FreeCAD and run

Code: Select all

import Test, TestFem
Test.runTestsFromModule(TestFem)

Code: Select all

import Test, femtest.testcommon
Test.runTestsFromClass(femtest.app.test_ccxtools.TestCcxTools)
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Minor Improvement for Task Panel ResultShow

Postby bernd » Tue Feb 18, 2020 4:49 am

I will fix the unit tests.
UR_
Posts: 1171
Joined: Tue Jan 03, 2017 8:42 pm

Re: Minor Improvement for Task Panel ResultShow

Postby UR_ » Tue Feb 18, 2020 6:31 am

bernd wrote:
Tue Feb 18, 2020 4:37 am
is there a special reason for deleting the try here: https://github.com/UR-0/FreeCAD/commit/ ... 1R324-R327
Code was commented out just for debugging reasons. Should be restored at releasing.
But perhaps you wanna do some testing before.
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Minor Improvement for Task Panel ResultShow

Postby bernd » Tue Feb 18, 2020 7:21 am

no histogramm for me ATM ... I might miss some packages on my linux machine ...

https://github.com/berndhahnebach/FreeC ... its/femtmp
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Minor Improvement for Task Panel ResultShow

Postby bernd » Tue Feb 18, 2020 4:50 pm

bernd wrote:
Tue Feb 18, 2020 7:21 am
no histogramm for me ATM ... I might miss some packages on my linux machine ...
no selected result type means no histogramm :oops:

merged and unit test fixed and code formating and debugging comments removed ...
UR_
Posts: 1171
Joined: Tue Jan 03, 2017 8:42 pm

Re: Minor Improvement for Task Panel ResultShow

Postby UR_ » Wed Feb 19, 2020 7:15 am

bernd wrote:
Tue Feb 18, 2020 4:50 pm
no selected result type means no histogramm :oops:
- Added a messagebox to give a hint in that case
- Added migration code to convert stat from old result object: (min, avg, max)->(min, max)

PR: https://github.com/FreeCAD/FreeCAD/pull/3079
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Minor Improvement for Task Panel ResultShow

Postby bernd » Wed Feb 19, 2020 8:37 am

merged and added the commit sha of origin change, this is the stuff which makes FreeCAD robust. We really need this, even if it is boring to develop.

cheers bernd