TestRequest and CodeReview, Exact cload for edges

About the development of the FEM module/workbench.

Moderator: bernd

User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

TestRequest and CodeReview, Exact cload for edges

Post by bernd »

I finished the cload implementation for edges. Did some changes in ccxwriter as well

https://github.com/berndhahnebach/FreeC ... loadedge01

http://pha.geofinder.eu/D21

I may add some files to test in another post
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: TestRequest and CodeReview, Exact cload for edges

Post by bernd »

some files to test with ...
line-load--solid-mesh.fcstd
(46.2 KiB) Downloaded 46 times
line-load--shell-mesh.fcstd
(11.56 KiB) Downloaded 46 times
line-load--beam-mesh.fcstd
(9.64 KiB) Downloaded 52 times
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: TestRequest and CodeReview, Exact cload for edges

Post by sgrogan »

So much FEM so little time, it's hard to keep up. :)
I put some win builds here:https://github.com/sgrogan/FreeCAD/rele ... .16-femdev
"fight the good fight"
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: TestRequest and CodeReview, Exact cload for edges

Post by PrzemoF »

I'm reading the code and in general it looks fine. I'm not analyzing how it works - it's too much for me today :-)
I found one thing that doesn't look nice - sortlistoflistvalues
I think there is no need to use a new list:

Code: Select all

>>> l = [[1,2,2,0],[2,5,1,2],[3,4,9,3,1],[9,2,5,7]]
>>> for e in l:
...     e.sort()
... 
>>> l
[[0, 1, 2, 2], [1, 2, 2, 5], [1, 3, 3, 4, 9], [2, 5, 7, 9]]
Back to the code...
Serchu
Posts: 107
Joined: Tue Feb 10, 2015 12:33 pm
Location: General Pacheco (Buenos Aires) - Argentina
Contact:

Re: TestRequest and CodeReview, Exact cload for edges

Post by Serchu »

Hi, very useful features, those builds are for Windows?

Regards
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: TestRequest and CodeReview, Exact cload for edges

Post by sgrogan »

Serchu wrote:Hi, very useful features, those builds are for Windows?
Yes, I can't build a proper debian or RPM package yet. Let alone an OSX app. So from me its always windows. :(
Please test well. I'm not familiar with the structural workflow w/ beam and shell elements or edge loads. We all need to keep the feature requests to a minimum during testing.
"fight the good fight"
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: TestRequest and CodeReview, Exact cload for edges

Post by bernd »

PrzemoF wrote:...I found one thing that doesn't look nice - sortlistoflistvalues
I think there is no need to use a new list:...
I tried this when I was developing the def. I would swear it did not work when tried it :o :shock:

I'm gone change it in in further version ... 8-)
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: TestRequest and CodeReview, Exact cload for edges

Post by PrzemoF »

I cannot find a link, but python sometimes does something unexpected when operating on parameters passed with a function, so you might be right that it doesn't work in a certain situation.
fandaL
Posts: 440
Joined: Thu Jul 24, 2014 8:29 am

Re: TestRequest and CodeReview, Exact cload for edges

Post by fandaL »

line-load--shell-mesh.fcstd
Seems to work.

line-load--solid-mesh.fcstd
When I run quick analysis "Write .inp file and run Calculix ccx", it gives me result. When I click to "Dialog to start the calculation of the mechanical analysis" it doesn't open task window to start analysis, only reports:

Code: Select all

Running the Python command 'Fem_MechanicalJobControl' failed:
Traceback (most recent call last):
  File "D:\soft\FreeCad\FreeCAD_0.16.5799_x64_dev_bin_femcloadedge01\Mod\Fem\_CommandMechanicalJobControl.py", line 48, in Activated
    taskd = _JobControlTaskPanel._JobControlTaskPanel(FemGui.getActiveAnalysis())
  File "D:\soft\FreeCad\FreeCAD_0.16.5799_x64_dev_bin_femcloadedge01\Mod\Fem\_JobControlTaskPanel.py", line 83, in __init__
    self.update()
  File "D:\soft\FreeCad\FreeCAD_0.16.5799_x64_dev_bin_femcloadedge01\Mod\Fem\_JobControlTaskPanel.py", line 164, in update
    if self.analysis_object.AnalysisType == 'static':

'FeaturePython' object has no attribute 'AnalysisType'
But when I create new MechanicalAnalysis and copy/paste all content to it, all works normally.

line-load--beam-mesh.fcstd
Similar problem with the same error report.
I'm able to do the same trick, but I must create new BeamSetion by hand, because I cannot paste it to the new MechanicalAnalysis.

Last note: I don't see anywhere units for Line load yet.

OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.16.5799 (Git)
Build type: Release
Branch: femcloadedge01
Hash: c760f6f9f6620327309868799f5d6161bd447006
Python version: 2.7.8
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 6.8.0.oce-0.17
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: TestRequest and CodeReview, Exact cload for edges

Post by PrzemoF »

That's OK - there were quite a few changes recently and it's normal and expected behaviour.
If you see any errors after creating the new analysis and moving the content then we have a bug.
Post Reply