https://github.com/FreeCAD/FreeCAD/pull/4379 I would like to get this into master.
- Would it be possible to rebase all on latest FreeCAD?
- Have you been coding according pep8?
add new function to fem module
Moderator: bernd
Forum rules
and Helpful information for the FEM forum
and Helpful information for the FEM forum
Re: add new function to fem module
I have not been coding specific for pep8, because I didn't know it existed. But I looked at your code and tried to copy that style/format.bernd wrote: ↑Fri May 07, 2021 4:15 pm https://github.com/FreeCAD/FreeCAD/pull/4379 I would like to get this into master.
- Would it be possible to rebase all on latest FreeCAD?
- Have you been coding according pep8?
I'll rebase the PR and review my code so that it's according to pep8.
Re: add new function to fem module
just realized latest FEM code had a few pep8 errors ... git commit 582621b3bcb4
Re: add new function to fem module
I've looked at this: https://www.python.org/dev/peps/pep-0008/
And tried to my best of my ability to reformat the code according to PEP8.
https://github.com/FreeCAD/FreeCAD/pull/4379
And tried to my best of my ability to reformat the code according to PEP8.
https://github.com/FreeCAD/FreeCAD/pull/4379
Re: add new function to fem module
Rebased it on master and will continue to do until it is merged ... https://github.com/berndhahnebach/FreeC ... embuckling
As you mentioned already ... mesh of ltb example really is huge. Either we accept the 3.4 MB mesh or we use gmsh to mesh it but than it will be difficult to make a unit test. But since we have another small example for a unit test this could be the way to go. How about this?
How about squashing the example commits into one for each example?
As you mentioned already ... mesh of ltb example really is huge. Either we accept the 3.4 MB mesh or we use gmsh to mesh it but than it will be difficult to make a unit test. But since we have another small example for a unit test this could be the way to go. How about this?
How about squashing the example commits into one for each example?
Re: add new function to fem module
Well, we could do that, or we could do the mesh significantly more coarse. What do you think is the limit of an example mesh size?bernd wrote: ↑Mon May 10, 2021 9:29 pm As you mentioned already ... mesh of ltb example really is huge. Either we accept the 3.4 MB mesh or we use gmsh to mesh it but than it will be difficult to make a unit test. But since we have another small example for a unit test this could be the way to go. How about this?
I'll have a look!