OpenSees, the Open System for Earthquake Engineering Simulation

About the development of the FEM module/workbench.

Moderator: bernd

User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by ebrahim raeyat »

for example, I must write almost all of this method in my opensees writer too:

https://github.com/ebrahimraeyat/FreeCA ... er.py#L384
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by bernd »

If we would be able to make them generic this would be great! You could give it a try in your opensees branch and move them out of the calculix writer. To test your work just run the FEM unit tests. If they will pass your are on the track :D
User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by ebrahim raeyat »

bernd wrote: Thu Apr 16, 2020 11:23 am If we would be able to make them generic this would be great! You could give it a try in your opensees branch and move them out of the calculix writer. To test your work just run the FEM unit tests. If they will pass your are on the track :D
thanks bernd, I will give it a try :D
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by Kunda1 »

ebrahim raeyat wrote: Thu Apr 16, 2020 6:31 pm thanks bernd, I will give it a try :D
This would push FEM forward big time, since it would decrease the barrier-to-entry for developers to add other 3rd party solvers. Please do this :D
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by ebrahim raeyat »

Kunda1 wrote: Sat Apr 18, 2020 3:03 pm
ebrahim raeyat wrote: Thu Apr 16, 2020 6:31 pm thanks bernd, I will give it a try :D
This would push FEM forward big time, since it would decrease the barrier-to-entry for developers to add other 3rd party solvers. Please do this :D
@bernd , @Kunda1, I sent you a PR for this, please look at this.
User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by ebrahim raeyat »

@bernd, how can I distinguish between beam and column in my model? at this time I take it by their direction:

https://github.com/ebrahimraeyat/FreeCA ... nts.py#L40

but I think if we add a property to element1D for this, it is better. at present for taking to account PDelta or large deformation I need to know the type of element (beam, column or brace), some times we need linear transformation for beam and PDelta for column:

https://opensees.berkeley.edu/wiki/inde ... on_Command

beside that in the future for design such an element we need the type of that.
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by bernd »

I will comment later on your last post ...

In the regard of your movement ...

I really like this one ... https://github.com/berndhahnebach/FreeC ... 1L118-R124 but this is far to much in one commit. If there will be problems it is difficault to find. I splitted this and merged some of it into master. git commit 1f595291a7 (BTW: you are official FreeCAD developer with this commit :D ) Above of this I made some more changes ... see git commit 9cd69ed7b, git commit 25e3004024, git commit 81be62cae5, git commit 89928ef1f5 There might be a few more before I can come back to opensees. ...
User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by ebrahim raeyat »

bernd wrote: Wed Apr 22, 2020 7:06 am (BTW: you are official FreeCAD developer with this commit :D )
I wanted to be an official developers of freecad :cry: ,
thank you @bernd. can I take your changes in my opensees branch or it's not require to pull it?
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by bernd »

This branch is rebased on master, https://github.com/berndhahnebach/FreeC ... emopensees

But ATM I reverted my changes back to your ccx writer. This needs to be tackled. But it might makes sense to wait until I have finisched changes on writer. https://github.com/berndhahnebach/FreeC ... e5de02e20d

Generally it would make sense to splitt different changes in different commits. For example one commit for the improvements in ccx writer and one commit for the move of the methods out of the writer. We would not have the trouble than just now.

We might switch to a newer branch for developing opensees. I will push some femopenseesebrahim2 later
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: OpenSees, the Open System for Earthquake Engineering Simulation

Post by bernd »

as a result of your changes in ccx writer I did move a lot of code around ... :D much better now especially for splitted file writting. Anyway ...

I retired the femopenseesebrahim to https://github.com/berndhahnebach/FreeC ... mopensees1

There is a new femopenseesebrahim on https://github.com/berndhahnebach/FreeC ... eesebrahim This is the one which is rebased on uptodate master. Best is if you replace your opensees branch with this one and we continue as before with PRs but with this new branches. Would check if I included all your changes? Hopefully I did not miss anything from your changes.

cheers bernd
Post Reply