Elmer Integration (GSoC) - Activity Log

Contributions from the participants, questions and answers to their projects.
Discussions of proposals for upcoming events.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Elmer Integration (GSoC) - Activity Log

Post by bernd »

m42kus wrote: Tue Jun 27, 2017 8:56 am Just looked at the source and notized that the variable names that are imported are hardcoded to "Displacement" and "Temperature". ElmerSolver names them "displacement" and 'temperature". I tried to change that but it seems like ElmerSolver ignores case... i already posted a question on elmer forum: http://www.elmerfem.org/forum/viewtopic ... b5fbdbea8e . However, would you (bernd or ickby) mind supporting both variants?

Edit: If it wasn't clear: After I changed them from "Displacement" and "Temperature" to "displacement" and "temperature" in the FreeCAD source the import worked ;)
For sure we should support any case. Someone could even try to import a vtk created with some totally different software.

@markus:
Would it be possible for you to make the appropriate changes in FreeCAD source code ?
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: Elmer Integration (GSoC) - Activity Log

Post by ickby »

I just checked. The VTK postprocessing objects are very much able to read all the available vtk files. However, file import was changed to not create a Vtk postprocessing object but a Mesh and result object. That is strange and should IMHO be changed back. Th eVtkPostprocessing is by default able to handle every result type that is available within the vtk file.

Anyway, for automatic loading of results you can use FemPostPipeline read functions to circumvent the freecad load logic:
https://github.com/FreeCAD/FreeCAD/blob ... line.h#L61
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: Elmer Integration (GSoC) - Activity Log

Post by ickby »

m42kus wrote: Tue Jun 27, 2017 9:26 am There is also the problem that the imported result object needs its own mesh (I'm guessing this is because of node numbering?). Also it's quite a pain to add support for additional variables. I think in the long run side stepping the result object completely and only using generic vtk result objects would be the best way to go. What do you (everyone ;)) think on that issue?
That was what I invisioned in the beginning. There are however two issues that need some work:
1. The normal viewprovider has been extended for all mesh types and I think also stuff like picking, this would need to be adopted
2. The default postprocess dialog may be redone for the vtk tools as this is a fast and convienient way of looking at things.

Annother nice property of the vtk tools is that they work on the vtkDataStructure, which is also used underneath SMESH. Hence with some clever coding it could be possible to use all the VTK postprocessing tools on the Mesh data structure. Imagine clipping while trying to create a good mesh: highly valuable!
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Elmer Integration (GSoC) - Activity Log

Post by bernd »

the CFD OpenFoam guys did some changes at vtk.

I totally agree with you guys (ickby and m42kus), but I see two problems. Someone needs to do the work and the main problem, someone needs to maintain the code day by day in conjunction with pull requests and so on.

There are a few people involved in FEM already, means regulary changes come in. I try to get rid of all bugs and problems in the Python FEM code but my C++ knowledge is to small to maintain the C++ FEM code.

But anyway we should go for it if someone is willing to do the work!

bernd
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Elmer Integration (GSoC) - Activity Log

Post by bernd »

m42kus
Posts: 159
Joined: Tue Sep 02, 2014 9:41 am

Re: Elmer Integration (GSoC) - Activity Log

Post by m42kus »

ickby wrote: Tue Jun 27, 2017 11:12 am Anyway, for automatic loading of results you can use FemPostPipeline read functions to circumvent the freecad load logic:
https://github.com/FreeCAD/FreeCAD/blob ... line.h#L61
Thanks very much for the tip. This is what I'm going to use. My plan is to use the pipeline the in the same way calculix uses the result object (meaning I will include it in the analysis as a member). Do you see any problems with this?
bernd wrote: Fri Jun 30, 2017 12:54 pm in the regard of groups ...
https://forum.freecadweb.org/viewtopic. ... 40#p176562
git commit efb87dc1
git commit 084e163


in the regard of selecting inner faces:
https://forum.freecadweb.org/viewtopic. ... 76#p146374
Thanks for the references.

Quick explanation for others: bernd, hoWil and I talked a lot about what should be done in the next two months yesterday. A big point of the discussion was meshing. We also taked about how to select hidden faces and much more. On monday I'm going to make a post about what has been discussed and decided.
My GSoC Devlog: ceeli.github.io/gsoc
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Elmer Integration (GSoC) - Activity Log

Post by bernd »

@Markus:

In the regard of SMesh these posts might be interesting as well:
https://forum.freecadweb.org/viewtopic. ... 10#p179140
https://forum.freecadweb.org/viewtopic. ... 20#p179141

as said I gone try to get some contact in the regard of Smesh.
m42kus
Posts: 159
Joined: Tue Sep 02, 2014 9:41 am

Re: Elmer Integration (GSoC) - Activity Log

Post by m42kus »

bernd wrote: Sat Jul 01, 2017 9:43 am as said I gone try to get some contact in the regard of Smesh.
Thaks again, that would be awesome.
My GSoC Devlog: ceeli.github.io/gsoc
m42kus
Posts: 159
Joined: Tue Sep 02, 2014 9:41 am

Re: Elmer Integration (GSoC) - Activity Log

Post by m42kus »

Last week bernd, HoWil and I sat down and laid out a detailed plan for the next month. One big point of the discussion were problems that be solved before I can start phase 3 (multiphysics).
This list is going to keep me occupied till next week. Im going to post regular updates in the next days of course ;). If you belief that there is another mayor issue that can't wait up until phase 3 is finished please let me know.
My GSoC Devlog: ceeli.github.io/gsoc
m42kus
Posts: 159
Joined: Tue Sep 02, 2014 9:41 am

Re: Elmer Integration (GSoC) - Activity Log

Post by m42kus »

Hi again,
One big point which I forgot to mention: bernd and I are preparing a pull request to get the code of phase 2 into master :D. This will hopefully be done before the end of next week.
My GSoC Devlog: ceeli.github.io/gsoc
Post Reply