Concrete branch ready for testing

About the development of the FEM module/workbench.

Moderator: bernd

User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sat Jun 15, 2019 8:12 pm

in your FreeCAD git dev repo:

Code: Select all

# add my repo as a remote repo (you only need to to this once!)
git remote add bernd https://github.com/berndhahnebach/FreeCAD_bhb

# fetch my repo (you need to do this every time there have been changes in my branch)
git fetch bernd

# if you only would like to test my femconcrete 
git chechout remotes/bernd/femconcrete
# there will be the message in the regard of detached head because you are not in a local branch

# compile and test and what ever

# a few days later or a few hours later, when I have made change, just
git fetch bernd
git checkout remotes/bernd/femconcrete
# compile test ...

# if you would like to add an own commit and are in my remote repo in detached head
git checkout -b somenameharrywouldliketogivehisdevelopment
User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sat Jun 15, 2019 8:18 pm

HarryvL wrote:
Sat Jun 15, 2019 2:32 pm
bernd wrote:
Sat Jun 15, 2019 12:28 pm
HarryvL wrote:
Sat Jun 15, 2019 10:46 am
"Data points in all amplitudes" ??
might be because of this https://forum.freecadweb.org/viewtopic. ... 10#p314611 open the dat file. You will find the sum of reaction forces.It is a great control of load sum.
:shock: only on femconcrete, or on master too?

That's a good addition, but is it a bug or should I change some of my input to make it work? Currently FC freezes at the end of an CCX analysis.
everything runs smooth here ...

Screenshot_20190615_221725.png
Screenshot_20190615_221725.png (257.63 KiB) Viewed 265 times
User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sat Jun 15, 2019 8:19 pm

- compile femconcrete
- start FreeCAD
- run code

Code: Select all

from femexamples.manager import *
doc = run_rcwall2d()
User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sat Jun 15, 2019 8:26 pm

HarryvL wrote:
Sat Jun 15, 2019 10:06 am
I am not sure what "reinforce_ratio" does/did. Is it this the minimum reinforcement ratio from input? That what is called r0 later on?
yes


HarryvL wrote:
Sat Jun 15, 2019 10:06 am
And reinforce_yield? Is this the input value of the yield strength of the steel? It is deleted and then added back in?
yes, this is just because of the way diff formats the changes.


HarryvL wrote:
Sat Jun 15, 2019 10:06 am
And where does that get linked to fy in the code? Anyway, it is probably easiest for me to just run a few test cases.
here is reinforce_yield https://github.com/berndhahnebach/FreeC ... #L448-L451 linked to fy https://github.com/berndhahnebach/FreeC ... ls.py#L607


HarryvL wrote:
Sat Jun 15, 2019 10:06 am
Can I pull this from your femconcrete branch?
yes, it has the latest concrete dev and it is rebased on FreeCAD master


HarryvL wrote:
Sat Jun 15, 2019 10:06 am
Deletion of scxx, yy, zz looks ok.
cool
User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sat Jun 15, 2019 8:30 pm

just another small improvement for better readable code ... https://github.com/berndhahnebach/FreeC ... t/49a71442
User avatar
HarryvL
Posts: 1052
Joined: Sat Jan 06, 2018 7:38 pm

Re: Concrete branch ready for testing

Postby HarryvL » Sun Jun 16, 2019 6:37 am

bernd wrote:
Sat Jun 15, 2019 8:12 pm
in your FreeCAD git dev repo:

Code: Select all

# add my repo as a remote repo (you only need to to this once!)
git remote add bernd https://github.com/berndhahnebach/FreeCAD_bhb

# fetch my repo (you need to do this every time there have been changes in my branch)
git fetch bernd

# if you only would like to test my femconcrete 
git chechout remotes/bernd/femconcrete
# there will be the message in the regard of detached head because you are not in a local branch

# compile and test and what ever

# a few days later or a few hours later, when I have made change, just
git fetch bernd
git checkout remotes/bernd/femconcrete
# compile test ...

# if you would like to add an own commit and are in my remote repo in detached head
git checkout -b somenameharrywouldliketogivehisdevelopment
Thanks, that worked.
User avatar
HarryvL
Posts: 1052
Joined: Sat Jan 06, 2018 7:38 pm

Re: Concrete branch ready for testing

Postby HarryvL » Sun Jun 16, 2019 6:54 am

bernd wrote:
Sat Jun 15, 2019 8:19 pm
- compile femconcrete
- start FreeCAD
- run code

Code: Select all

from femexamples.manager import *
doc = run_rcwall2d()
This works Bernd. It also works with my other old files. There must have been something wrong with the old file for the one case I tried first
User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sun Jun 16, 2019 11:45 am

what else is needed before merge into master?

From my point we should go for a merge!
User avatar
HarryvL
Posts: 1052
Joined: Sat Jan 06, 2018 7:38 pm

Re: Concrete branch ready for testing

Postby HarryvL » Sun Jun 16, 2019 12:18 pm

bernd wrote:
Sun Jun 16, 2019 11:45 am
what else is needed before merge into master?

From my point we should go for a merge!
As far as I can see this is production ready. Hopefully others will give it a try so further bugs can be found
User avatar
bernd
Posts: 8465
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Concrete branch ready for testing

Postby bernd » Sun Jun 16, 2019 4:31 pm