feature: general initial value and body source, to be tested

[qingfeng.xia]

that is silly error, should be x- y- z-component.
I also have another way to input vector, just as C++ constraint type (direction + mag), I have not fully tested, could be added in the future

https://github.com/berndhahnebach/FreeC ... get.py#L96

Code: Select all

            self.componentLabels = ["x-component", "x-component", "x-component"]

Why three times x-component?

[qingfeng.xia]

IMHO it shoudl be named FemConstraintGeneric instead FemGenericConstraint

It should be easy to just do find and replacement. I will do it later.
I am stuck on the json serialization error.

[qingfeng.xia]

IMHO it shoudl be named FemConstraintGeneric instead FemGenericConstraint

A new PR has been sent to your fembodyconstraint branch. I pull your branch on Tuesday, it still show merge conflict, not sure why.

1. Class rename
2. Json serializable error fixed

[bernd]

great, nevermind about the merge conflict ...

[bernd]

2. Json serializable error fixed

which part of the code does fix this erro ? I run into the same problem https://forum.freecadweb.org/viewtopic.php?f=18&t=44021

[bernd]

merged your code and did myself some code formating and renaming to fit all generic constraint code in FEM code conventions. https://github.com/berndhahnebach/FreeC ... 5bb5176d65 in branch https://github.com/berndhahnebach/FreeC ... constraint

The Json serializable error still resists ...


https://github.com/FreeCAD/FreeCAD/comp ... 5bb5176d65 (all changes so far)

[bernd]

2. Json serializable error

see here for more information https://forum.freecadweb.org/viewtopic.php?f=18&t=44021

[bernd]

would you give https://github.com/berndhahnebach/FreeC ... constraint a try ?

[qingfeng.xia]

add those 2 dumb functions to viewprovider class, in addition to _FemConstraintGeneric.py class. It fixed json error for me.
This solution is aslo form FreeCAD forum.https://forum.freecadweb.org/viewtopic. ... 94#p373094

src/Mod/Fem/femguiobjects/_ViewProviderFemGenericConstraint.py

Code: Select all

    def __getstate__(self):
        return None

    def __setstate__(self,state):
        return None

I read your latest branch, you have deleted those 3 functions from _FemConstraintGeneric.py

Code: Select all

    def execute(self, obj):
        ''' Called on document recompute '''
        return

    def __getstate__(self):
        # Called during document saving
        return self.Type

    def __setstate__(self, state):
        if state:
            self.Type = state

Those 3 functions should be taken back. and also some comment to protect those dumb functions , not to be deleted in the future.

The Json serializable error still resists ...

https://github.com/FreeCAD/FreeCAD/comp ... 5bb5176d65 (all changes so far)

[bernd]

no they need not! Everything should work fine so far! They where missing in the superclass!

Would you give it a try?