FEM example files miss thumbnails

About the development of the FEM module/workbench.

Moderator: bernd

User avatar
uwestoehr
Posts: 690
Joined: Sun Jan 27, 2019 3:21 am

FEM example files miss thumbnails

Postby uwestoehr » Wed Mar 13, 2019 12:22 am

With the FC preferences option (section General->Document) "Save thumbnail into project file..." one can save FCStd files with a thumbnail image. This useful in my opinion for the FEM example files but unfortunately, in FC 0.18 this is not the case, see this screenshot:
Image
https://www.freecadweb.org/wiki/File:St ... enshot.jpg

You can see that e.g. the Example EngineBlock has a thumbnail image.
User avatar
bernd
Posts: 8329
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: FEM example files miss thumbnails

Postby bernd » Fri Mar 15, 2019 4:15 pm

Wow cool I did not know how simple it is to create them, but to late for 0.18 .... I am quite buisy ATM. Change this and make a PR your self or create an issue and assign it to me. So we do not forget about this before 0.19

bernd
fandaL
Posts: 338
Joined: Thu Jul 24, 2014 8:29 am

Re: FEM example files miss thumbnails

Postby fandaL » Sat Mar 16, 2019 10:39 am

I loaded and saved example files with thumbnails in FC 0.18.16093. Commit is here:

https://github.com/fandaL/FreeCAD/commi ... 5a0ab257d8
User avatar
bernd
Posts: 8329
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: FEM example files miss thumbnails

Postby bernd » Thu Mar 21, 2019 10:24 am

great! Would it be possible to update the PR, because the FEM examples have been updated in master recently ... :oops:

https://github.com/FreeCAD/FreeCAD/pull/2019
User avatar
uwestoehr
Posts: 690
Joined: Sun Jan 27, 2019 3:21 am

Re: FEM example files miss thumbnails

Postby uwestoehr » Thu Mar 21, 2019 10:33 am

bernd wrote:
Thu Mar 21, 2019 10:24 am
https://github.com/FreeCAD/FreeCAD/pull/2019
I think it is better that you already provide the updated example files with thumbnails.
fandaL
Posts: 338
Joined: Thu Jul 24, 2014 8:29 am

Re: FEM example files miss thumbnails

Postby fandaL » Fri Mar 22, 2019 9:32 pm

bernd wrote:
Thu Mar 21, 2019 10:24 am
great! Would it be possible to update the PR, because the FEM examples have been updated in master recently ... :oops:

https://github.com/FreeCAD/FreeCAD/pull/2019
I recreated it in the new branch (since first one was in my master and during cleaning I swept it all).
https://github.com/fandaL/FreeCAD/commi ... 8d17429a8b
The new commit includes FEM examples from the actual source, but I opened and saved it in the FC0.18.16093 (downloaded before you created new examples). Is it ok?


btw
It should be easy to set your FC to save thumbnails as uwestoehr mentioned
uwestoehr wrote:
Wed Mar 13, 2019 12:22 am
With the FC preferences option (section General->Document) "Save thumbnail into project file..." one can save FCStd files with a thumbnail image.