Request: Can someone run flake8/pep8 on a FEM source file?

About the development of the FEM module/workbench.

Moderator: bernd

Post Reply
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Request: Can someone run flake8/pep8 on a FEM source file?

Post by Kunda1 »

Running a translation update on FEM i get

Code: Select all

resulttools.py: Unbalanced parentheses in Python code
I'm having trouble running pep8/flake8 on FreeCAD/src/Mod/Fem/femresult/resulttools.py can someone do that and post back
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Request: Can someone run flake8/pep8 on a FEM source file?

Post by bernd »

I am on the way, no linux machine around ... :evil: Do you have a line number ?
chrisb
Veteran
Posts: 54287
Joined: Tue Mar 17, 2015 9:14 am

Re: Request: Can someone run flake8/pep8 on a FEM source file?

Post by chrisb »

I can load resulttools.py as a macro without any syntax error. (Of course nothing happens if I do so.)
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Request: Can someone run flake8/pep8 on a FEM source file?

Post by Kunda1 »

bernd wrote: Thu Jun 03, 2021 5:57 am Do you have a line number ?
No line number, unfortunately. The warning is very general. I need to check the src/Tools/updatets.py script to see if I can make the output more verbose.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Request: Can someone run flake8/pep8 on a FEM source file?

Post by bernd »

all good here

Code: Select all

$
$ git log -1
commit 1bea75d62b012fbd49ffce3d34da4e8ce00a3f16 (HEAD, sfmaster/master, origin/master, origin/femdev, origin/HEAD)
Author: Bernd Hahnebach <bernd@bimstatik.org>
Date:   Wed Jun 9 08:01:55 2021 +0200

    FEM: code formating
$ 
$ 
$ flake8 --ignore=E266,W503 --max-line-length=100 src/Mod/Fem/femresult/resulttools.py
$ 
$ 
$ flake8 --ignore=,W503 --max-line-length=100 src/Mod/Fem/femresult/resulttools.py
src/Mod/Fem/femresult/resulttools.py:26:1: E266 too many leading '#' for block comment
src/Mod/Fem/femresult/resulttools.py:857:1: E266 too many leading '#' for block comment
$ 
Post Reply