Problems with the Active Body highlight color.

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
User avatar
NormandC
Posts: 16566
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Problems with the Active Body highlight color.

Postby NormandC » Sun Sep 09, 2018 7:03 am

Another suggestion: automatically expand the content of a Body when we create it or activate it. It would make sense for two reasons: you almost always want to see the content of a Body you are working on (at least I do, and having to manually expand it every time is an annoyance); plus, upon creation/activation, it is still selected, so there is no visual cue that it was just activated. With the expanding of its content, with said content highlighted, this would improve noticeability.

Corollary suggestion: when deactivating a Body, collapse its content?

In both cases, it may be judicious to provide the option to disable this behavior.
chrisb
Posts: 10339
Joined: Tue Mar 17, 2015 9:14 am

Re: Problems with the Active Body highlight color.

Postby chrisb » Sun Sep 09, 2018 9:18 am

Another possibility would be to modify the body's symbolin the same as the Tip. Of course it could be something different but
- the symbol and the technique of showing it is readily available
- The Tip can well be seen as the active element inside the body; so it's not a semantic cut.
User avatar
NormandC
Posts: 16566
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Problems with the Active Body highlight color.

Postby NormandC » Sun Sep 09, 2018 8:29 pm

I've thought about it too, but the problem is that such a tiny symbol overlaid on the regular Body icon would not be as easily noticeable. It is obvious from a recent topic that it really needs to be unmissable.
User avatar
sliptonic
Posts: 1231
Joined: Tue Oct 25, 2011 10:46 pm

Re: Problems with the Active Body highlight color.

Postby sliptonic » Sun Sep 09, 2018 11:27 pm

I like the idea. There might be some initial confusion since it looks vaguely like a multi-selection but that's nothing. it'll only take the user a few seconds to realize that isn't the case.
wmayer
Site Admin
Posts: 13077
Joined: Thu Feb 19, 2009 10:32 am

Re: Problems with the Active Body highlight color.

Postby wmayer » Mon Sep 10, 2018 12:15 pm

NormandC wrote:But how are we to know how to enable it? There is nothing in BaseApp/Preferences/View about Active Body label font style. Do we need to create it from scratch, and if so, what name and value to give it?
Yes, you have to create the keys from scratch: https://github.com/FreeCAD/FreeCAD/blob ... .cpp#L1304
NormandC wrote:How about propagating the active highlight color to the Body's content? With all of it having the highlight color, it would be more noticeable.
This will cause other problems. The tree view doesn't know what a body or part container is, instead it gets a signal from the document if an object has been activated to render this is in a special mode.
Now it's possible that you have a Part container containing several bodies and following your logic you must show all child objects inside the part container with the purple background when you activate it. So, this means that also the child objects of an inactive body is rendered with this background color.
wmayer
Site Admin
Posts: 13077
Joined: Thu Feb 19, 2009 10:32 am

Re: Problems with the Active Body highlight color.

Postby wmayer » Mon Sep 10, 2018 12:26 pm

With git commit 34a0c7bce the activated object (body, part container, ...) is now in bold text.
chrisb
Posts: 10339
Joined: Tue Mar 17, 2015 9:14 am

Re: Problems with the Active Body highlight color.

Postby chrisb » Mon Sep 10, 2018 2:38 pm

Thank you!
User avatar
NormandC
Posts: 16566
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Problems with the Active Body highlight color.

Postby NormandC » Sun Sep 23, 2018 11:43 pm

Thanks.

wmayer wrote:
Mon Sep 10, 2018 12:15 pm
This will cause other problems. The tree view doesn't know what a body or part container is, instead it gets a signal from the document if an object has been activated to render this is in a special mode.
Now it's possible that you have a Part container containing several bodies and following your logic you must show all child objects inside the part container with the purple background when you activate it. So, this means that also the child objects of an inactive body is rendered with this background color.
That's unfortunate. It's always trickier than we non-programmer think, isn't it. :D

The new behaviour (bold text, automatic expand/collapse) will hopefully be enough.