Possible issues in datum objects command

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Possible issues in datum objects command

Post by jnxd »

A couple of issues I noticed in the datum commands

First is clearly a bug. Steps to reproduce:
1) In PartDesign, press command to make any datum object
2) In the task view, press cancel

The datum object still remains in the tree. Is this intended?

Second (and evidently not as major), when used without an active body, datum objects seem to want to use a different warning than the rest of the features, apart from sketch and primitives.
error-pd-other-features.png
error-pd-other-features.png (30.79 KiB) Viewed 4374 times
error-pd-datum-commands.png
error-pd-datum-commands.png (13.04 KiB) Viewed 4374 times
But where sketch and primitive commands throw this warning themselves because they create a new body if none exists, datum commands do no such things. If we could use the same warning (thrown in PartDesignGui::getBody()), we could be able to use the same new "active body required" dialog I describe in this thread, though making a different one for datum objects is not hard if needed.

Version details (also happens in an master as of a few hours ago):
OS: Ubuntu 20.04.2 LTS (MATE/mate)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Branch: unknown
Hash: 0d9536ed3e8c7f40197b5606e1b7873625e1d6fe
Python version: 3.8.10
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.2
Locale: English/United States (en_US)
My latest (or last) project: B-spline Construction Project.
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: Possible issues in datum objects command

Post by jnxd »

Oops, it seems the first issue has already been reported a couple months ago here: https://forum.freecadweb.org/viewtopic.php?f=19&t=58342.
My latest (or last) project: B-spline Construction Project.
Post Reply