PDN + Linear or Polar pattern allways stay last in feature tree

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
babaroga
Posts: 180
Joined: Sun Aug 14, 2016 6:52 pm
Location: Banja Luka, Republic of Srpska, Bosnia and Herzegovina

PDN + Linear or Polar pattern allways stay last in feature tree

Post by babaroga »

I am experiencing certain problem with use of linear or polar patterns. After creation of some patern, it allways stay last in feature tree an any new feature or sketch made, is placed beforre it.

Code: Select all

OS: Ubuntu 17.04
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.12113 (Git)
Build type: Unknown
Branch: master
Hash: 09737f2db30ad13ce5600b2c2dcd4786c7699d26
Python version: 2.7.13
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: English/UnitedStates (en_US)
So steps to reproduce are as follows:

1. Create new FreeCAD document and switch to Part Design
2. Create New Body
3. Create New Sketch and base it on XY plane. Draw something, eg. circle with 50mm radius
4. Pad the sketch, and make direction reverse, so it is extruded downwards.
Screenshot_20170917_180504.png
Screenshot_20170917_180504.png (95.78 KiB) Viewed 1866 times
5. Then I will make another sketch on XY plane, eg. 10mm circle with center 40 mm from origin.
6. Pad second sketch
Screenshot_20170917_181139.png
Screenshot_20170917_181139.png (82.13 KiB) Viewed 1866 times
7. Now, I will make Polar pattern of second pad, eg. full circle with 4 occurences.
Screenshot_20170917_181813.png
Screenshot_20170917_181813.png (100.51 KiB) Viewed 1866 times
8. I will create a new sketch on XY eg. 20mm circle in origin. Sketch is placed before Polar pattern!!!
Screenshot_20170917_182231.png
Screenshot_20170917_182231.png (111.94 KiB) Viewed 1866 times
9. When I Pad or Pocket this sketch, it overrides Polar pattern...
Screenshot_20170917_182520.png
Screenshot_20170917_182520.png (98.93 KiB) Viewed 1866 times
10. If Pocket is manually moved behind Polar pattern (Move object after other object), I get expected appearance.

11. If you try to add New sketch or additive primitive, it will, again, be placed before Polar pattern...

Is anyone else experiencing this?
User avatar
babaroga
Posts: 180
Joined: Sun Aug 14, 2016 6:52 pm
Location: Banja Luka, Republic of Srpska, Bosnia and Herzegovina

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by babaroga »

Here is expected result
Screenshot_20170917_183054.png
Screenshot_20170917_183054.png (102.07 KiB) Viewed 1861 times
..and file in attachment
Attachments
Pattern with messed tree.fcstd
(21.13 KiB) Downloaded 54 times
chrisb
Veteran
Posts: 54303
Joined: Tue Mar 17, 2015 9:14 am

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by chrisb »

I ran into the same problem with a linear pattern. It is not possible to attach a sketch to a face of the pattern, it is always attached to the base feature of the pattern. Setting Tip does not help.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
babaroga
Posts: 180
Joined: Sun Aug 14, 2016 6:52 pm
Location: Banja Luka, Republic of Srpska, Bosnia and Herzegovina

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by babaroga »

You see, problem is that pattern (linear or polar) does not become Tip of the Body. After creation of any pattern (linear or polar), if you right-click on it in tree and select "Set Tip", everything works normal, or at least as intended.
chrisb
Veteran
Posts: 54303
Joined: Tue Mar 17, 2015 9:14 am

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by chrisb »

babaroga wrote: Fri Sep 22, 2017 6:33 am You see, problem is that pattern (linear or polar) does not become Tip of the Body. After creation of any pattern (linear or polar), if you right-click on it in tree and select "Set Tip", everything works normal, or at least as intended.
If you "Set Tip" can you attach a sketch to the pattern? Would you mind checking the dependency graph?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
babaroga
Posts: 180
Joined: Sun Aug 14, 2016 6:52 pm
Location: Banja Luka, Republic of Srpska, Bosnia and Herzegovina

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by babaroga »

Yes, I can!

Screenshot_20170922_111808.png
Screenshot_20170922_111808.png (157.44 KiB) Viewed 1785 times
Screenshot_20170922_111839.png
Screenshot_20170922_111839.png (205.98 KiB) Viewed 1785 times
chrisb
Veteran
Posts: 54303
Joined: Tue Mar 17, 2015 9:14 am

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by chrisb »

Thanks, I will check later, what's going on here.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
babaroga
Posts: 180
Joined: Sun Aug 14, 2016 6:52 pm
Location: Banja Luka, Republic of Srpska, Bosnia and Herzegovina

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by babaroga »

I checked today on my friends computer, same behavior also on windows box. He has 0.17 revision 12223.

He also have one older revision 10760 and everything works as expected.

:?
wmayer
Founder
Posts: 20324
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by wmayer »

git commit 16d4105 fixes it for transform features like mirror, linear pattern and polar pattern. A fix is still needed to make it work for multi-transform features.
User avatar
babaroga
Posts: 180
Joined: Sun Aug 14, 2016 6:52 pm
Location: Banja Luka, Republic of Srpska, Bosnia and Herzegovina

Re: PDN + Linear or Polar pattern allways stay last in feature tree

Post by babaroga »

Thank you. I can confirm it is fixed now.

I also did some tests with multitransform and it works as expected too.
Post Reply