[Fixed] Bug: Sketcher makes FreeCAD crash as soon as a tool is selected

[jmaustpc]

Same issue on ubuntu from upgrade of november 20.

I deleted your duplicate post, if I missed something please post again.

[looo]

I can confirm the problem ubuntu17.04/16.04 12624. Testing the latest commits it seems to be related to this commit: https://github.com/FreeCAD/FreeCAD/comm ... a114ce9213

[wmayer]

Is the crash random or does it happen all the time?

[sebste]

Happens every time you click one of the tools in sketcher.

[S.N.A.L]

https://forum.freecadweb.org/viewtopic. ... 5b37b5810f

[wmayer]

I get no crash at all, neither on Windows nor on Ubuntu 14.04 nor on Ubuntu 16.04.
But if someone could test if replacing the line

Code: Select all

static char cursor_crosshair_color[11];

with

Code: Select all

static char cursor_crosshair_color[12];

fixes it.

If not then it should be also checked if replacing

Code: Select all

unsigned long color = 0xFFFFFFFF; // white

with

Code: Select all

unsigned int color = 0xFFFFFFFF; // white

fixes it.

[looo]

Code: Select all

static char cursor_crosshair_color[12];

solves the problem.

[wmayer]

OK, the problem then is that the buffer is too short to add the null-termination character at the end.

[freecad-heini-1]

The same bug in the German forum:
https://forum.freecadweb.org/viewtopic. ... 46#p200646

[wmayer]

According to looo (thanks for testing!) this should fix the crash: git commit 399dca7