Expression changes are too easy to discard

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
nahshon
Posts: 192
Joined: Wed Jul 24, 2013 8:06 pm

Expression changes are too easy to discard

Postby nahshon » Wed Aug 22, 2018 10:16 pm

In the picture there are two views of the expression dialog. One in the sketcher and the other in the property view.

This is specially confusing in the sketcher, as there are two adjacent "OK" buttons, pressing the wrong "OK" will discard any changes done in the expression dialog.

The easy way to resolve this would be to make that dialog modal. There may be better solutions (Modal dialogs are evil).

If there is agreement I will open a case on Mantis.

-- Itai

OS: "Fedora release 28 (Twenty Eight)"
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14432 (Git)
Build type: Debug
Branch: master
Hash: 0252e491d5564e94ed8b1ba6d9b1e5b2a6c54483
Python version: 2.7.15
Qt version: 4.8.7
Coin version: 3.1.3
OCC version: 6.9.1.oce-0.18
Locale: English/UnitedStates (en_US)
Untitled.png
Untitled.png (31.78 KiB) Viewed 712 times
chrisb
Posts: 19645
Joined: Tue Mar 17, 2015 9:14 am

Re: Expression changes are too easy to discard

Postby chrisb » Wed Aug 22, 2018 11:53 pm

We had already a discussion about that dialog in sketcher. Has anyone bookmarked it?
wmayer
Site Admin
Posts: 14999
Joined: Thu Feb 19, 2009 10:32 am

Re: Expression changes are too easy to discard

Postby wmayer » Thu Aug 23, 2018 10:24 am

git commit 93163b28d hides/shows the button box of the parent dialog when formula editor opens/closes.
nahshon
Posts: 192
Joined: Wed Jul 24, 2013 8:06 pm

Re: Expression changes are too easy to discard

Postby nahshon » Fri Aug 24, 2018 9:42 am

Thanks!