Changing pad length in property editor does not update gui for latest dev version

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
User avatar
f3nix
Posts: 299
Joined: Sat May 30, 2015 11:58 am

Re: Changing pad length in property editor does not update gui for latest dev version

Postby f3nix » Wed Apr 17, 2019 5:27 pm

wmayer wrote:
Tue Nov 20, 2018 1:55 pm
No, I don't have to click the Recompute if I don't want to. I can click the Recompute button if the editor widget that has changed a property still has the focus to manually update the document. Otherwise the document will be updated automatically as soon as the editor widget loses the focus.
Hi @wmayer.

I can confirm change in the behaviour.
I have traced the commit that introduced it: 442e2dd381f012cb190aeb862f289ce4f70eae01

To reproduce it change the property value and hit enter key. When the property loses focus the document is not updated. You have to recompute manually.

Before this commit you could change the value and hit enter and the document would update automatically.

Code: Select all

OS: Debian GNU/Linux buster/sid
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15183 (Git)
Build type: Debug
Branch: (no branch, bisect started on 0e948db5a)
Hash: 442e2dd381f012cb190aeb862f289ce4f70eae01
Python version: 2.7.16
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Polish/Poland (pl_PL)
Cheers,
Mateusz
wmayer
Site Admin
Posts: 14423
Joined: Thu Feb 19, 2009 10:32 am

Re: Changing pad length in property editor does not update gui for latest dev version

Postby wmayer » Thu Apr 18, 2019 12:40 pm

To reproduce it change the property value and hit enter key. When the property loses focus the document is not updated. You have to recompute manually.
So, the difference is to press the Enter/Return key which is actually not needed at all. However, I can confirm when doing so it doesn't recompute the document. I'll put it on my to-do list.
chrisb
Posts: 16836
Joined: Tue Mar 17, 2015 9:14 am

Re: Changing pad length in property editor does not update gui for latest dev version

Postby chrisb » Thu Apr 18, 2019 5:27 pm

We have discussed this in some other topic: Tab recomputes, while enter only marks for recompute. I would expect it to be the other way round.
User avatar
f3nix
Posts: 299
Joined: Sat May 30, 2015 11:58 am

Re: Changing pad length in property editor does not update gui for latest dev version

Postby f3nix » Sat Apr 20, 2019 6:03 am

wmayer wrote:
Thu Apr 18, 2019 12:40 pm
I'll put it on my to-do list.
Thank you.

Cheers,
Mateusz