Performance improvements for PartDesign patterns (PR)

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Bance
Veteran
Posts: 4163
Joined: Wed Feb 11, 2015 3:00 pm
Location: London

Re: Performance improvements for PartDesign patterns (PR)

Post by Bance »

davidosterberg wrote: Sun Feb 28, 2021 3:27 pm ping
David I've managed to self compile FC, what would be the next step for testing? Could you point me to a link describing the process?

Thanks Steve.
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Re: Performance improvements for PartDesign patterns (PR)

Post by davidosterberg »

Bance wrote: Wed Mar 03, 2021 8:39 am David I've managed to self compile FC, what would be the next step for testing? Could you point me to a link describing the process?
Excellent.

Do you have git installed, are you on windows, linux or mac?
I assume that you have a working git, otherwise install it.

Since you have already self compiled FreeCAD, perhaps you can skip to step 2.

1. Open a command terminal and type

Code: Select all

cd "folder where you want to have the FreeCAD source"
git clone git@github.com:FreeCAD/FreeCAD.git
2. In the terminal type

Code: Select all

cd FreeCAD
git fetch origin pull/4504/head:pd-fix-pattern
git checkout pd-fix-pattern
3. Now compile and test away.
Bance
Veteran
Posts: 4163
Joined: Wed Feb 11, 2015 3:00 pm
Location: London

Re: Performance improvements for PartDesign patterns (PR)

Post by Bance »

Ok something not right here!

Code: Select all

bance@bance-OptiPlex-755:~/freecad-source$ git fetch origin pull/4504/head:pd-fix-pattern
remote: Enumerating objects: 34, done.
remote: Counting objects: 100% (34/34), done.
remote: Total 39 (delta 34), reused 34 (delta 34), pack-reused 5
Unpacking objects: 100% (39/39), 5.22 KiB | 34.00 KiB/s, done.
From https://github.com/FreeCAD/FreeCAD
 * [new ref]               refs/pull/4504/head -> pd-fix-pattern

Code: Select all

bance@bance-OptiPlex-755:~/freecad-source$ git checkout pd-fix-pattern
Switched to branch 'pd-fix-pattern'
Switch to build Dir

Code: Select all

bance@bance-OptiPlex-755:~/freecad-build$ cmake .

Code: Select all

bance@bance-OptiPlex-755:~/freecad-build$ make -j$(nproc --ignore=2) *****SNIP*****
[100%] Built target Example_data
So the build succeeds but when I open FC it doesn't have your patch?
Snip macro screenshot-4285a7.png
Snip macro screenshot-4285a7.png (34.83 KiB) Viewed 2465 times
What have I bu****ed up?
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Re: Performance improvements for PartDesign patterns (PR)

Post by davidosterberg »

Bance wrote: Wed Mar 03, 2021 2:01 pm ...
It seems right until the last step. Now, I am no CMAKE expert. I follow the trial and error approach there. But I suggest that you type something like:

Code: Select all

bance@bance-OptiPlex-755:~/freecad-build$ cmake ../freecad-source
Personally I have more commands to cmake. Like this:

Code: Select all

bance@bance-OptiPlex-755:~/freecad-build$ cmake ../freecad-source  -DBUILD_QT5=ON -DPYTHON_EXECUTABLE=/usr/bin/python3
Bance
Veteran
Posts: 4163
Joined: Wed Feb 11, 2015 3:00 pm
Location: London

Re: Performance improvements for PartDesign patterns (PR)

Post by Bance »

I don't want to de-rail this thread, I'll open a new one in Install/Compile.
Post Reply