Suggestion for Symmetry Constrant Symbol Enhancement

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby abdullah » Wed Aug 27, 2014 1:23 pm

Integrated!! Seems to look slightly better (well there is more space, it must!! :-) ).
constraints_5.png
constraints_5.png (21.38 KiB) Viewed 2235 times
Well, unless I did something terribly wrong, this should be it. Give it a run, and give me the green light for the pull request!!
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby abdullah » Wed Aug 27, 2014 3:12 pm

I have prepared a new branch rebased to today's master, including 4 commits. I have squashed everything to this 4 commits so that each separate functionality can be disabled in the future without affecting the others.

Jim, if you are satisfied with the result, you can do the honors and post a Pull request pointing to this thread (and you will get a +1 in your personal challenge of arriving to Werner's and Normand's number of posts :lol: ), if not let me know.

To https://github.com/abdullahtahiriyo/Fre ... master.git
* [new branch] sketcher_symmetry_constraint_rebased -> sketcher_symmetry_constraint_rebased

Code: Select all

commit 956949c87fae67d154b9d4b59ec65e4686ffb86a
Author: Abdullah Tahiri <abdullah.tahiri.yo@gmail.com>
Date:   Wed Aug 27 15:11:33 2014 +0200

    Sketcher Art enhancement: New Symmetric constraint icon by Jim
    
    There is more space in between the > < symbols now, so it is more clear as it overlaps less.
    
    Thanks Jim!

commit 155e52335610e3c36b0d0b6fe72c59c35a0cf66a
Author: Abdullah Tahiri <abdullah.tahiri.yo@gmail.com>
Date:   Wed Aug 27 14:58:35 2014 +0200

    Sketcher Bug fix: Arrows for symmetry constraint are back
    
    The arrows were there in the code, but at a certain point, code was written to set the this->imgHeight value programatically, based on
    whether it had text or not. As symmetry constraint does not have text the variable failed to initialize. Being zero, it did not pass
    the ASSERT in the render function, so it was not rendered.

commit 805621a9ba1bbf88c1b249d43482959ff8288713
Author: Abdullah Tahiri <abdullah.tahiri.yo@gmail.com>
Date:   Sun Aug 24 09:12:11 2014 +0200

    Sketcher visualization enhancement: Do not group sketcher symmetry icons.
    
    Do not add a symmetry constraint icon to a group of icons, so that it lies on the line or point providing the symmetry (symmetry axis/point),
    as it is more clear to the user which line this is.

commit 81d0b11ff2f5cd6d854b868a80658fea2f6b17b4
Author: Abdullah Tahiri <abdullah.tahiri.yo@gmail.com>
Date:   Sat Aug 23 06:30:48 2014 +0200

    Sketcher feature enhancement: Symmetry constraint perpendicular to axis of symmetry
    
    Solves Mantis ticket: http://www.freecadweb.org/tracker/view.php?id=1623
    Unrelated minor fix: remove unused variable
User avatar
DevJohan
Posts: 41
Joined: Sun Jul 13, 2014 2:36 pm
Location: Stockholm, Sweden

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby DevJohan » Wed Aug 27, 2014 8:40 pm

Nice work!
jmaustpc
Posts: 9619
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby jmaustpc » Thu Aug 28, 2014 9:45 am

abdullah wrote:I have prepared a new branch rebased to today's master, including 4 commits. I have squashed everything to this 4 commits so that each separate functionality can be disabled in the future without affecting the others.

Jim, if you are satisfied with the result, you can do the honors and post a Pull request pointing to this thread (and you will get a +1 in your personal challenge of arriving to Werner's and Normand's number of posts :lol: ), if not let me know.

To https://github.com/abdullahtahiriyo/Fre ... master.git
* [new branch] sketcher_symmetry_constraint_rebased -> sketcher_symmetry_constraint_rebased

Thanks for all your work Abdullah
I will have a look and post a request as soon as I can.

:)

Jim
jmaustpc
Posts: 9619
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby jmaustpc » Thu Aug 28, 2014 3:57 pm

Hi Abdullah
I get a cmake error and can't build this branch. Cmake adds a back slash into the file path hence errors out...

I see that the PPA did not build today, I have not looked at the details, but is there any chance that this is an error in master and you just had really bad luck with the timing of your rebase?

Jim
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby abdullah » Thu Aug 28, 2014 4:29 pm

I checked it... now I am not in front of the PC, i will look into it and come back to you.
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Suggestion for Symmetry Constrant Symbol Enhancement

Postby abdullah » Fri Aug 29, 2014 12:15 pm

Ok, I have just compiled it and works for my configuration:

OS: Ubuntu 12.04.5 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.15.3930 (Git)
Branch: sketcher_symmetry_constraint_rebased
Hash: 956949c87fae67d154b9d4b59ec65e4686ffb86a
Python version: 2.7.3
Qt version: 4.8.1
Coin version: 3.1.3
SoQt version: 1.5.0
OCC version: 6.7.0

I always build debug, but that should not be a problem...

I am going to ask for the pull request myself, maybe it is related, as you say, to the code in master when I rebased the branch, maybe I went in the middle of some compiler option fixes, that still works for my system, but not for yours...