Code: Select all
commit 956949c87fae67d154b9d4b59ec65e4686ffb86a Author: Abdullah Tahiri <email@example.com> Date: Wed Aug 27 15:11:33 2014 +0200 Sketcher Art enhancement: New Symmetric constraint icon by Jim There is more space in between the > < symbols now, so it is more clear as it overlaps less. Thanks Jim! commit 155e52335610e3c36b0d0b6fe72c59c35a0cf66a Author: Abdullah Tahiri <firstname.lastname@example.org> Date: Wed Aug 27 14:58:35 2014 +0200 Sketcher Bug fix: Arrows for symmetry constraint are back The arrows were there in the code, but at a certain point, code was written to set the this->imgHeight value programatically, based on whether it had text or not. As symmetry constraint does not have text the variable failed to initialize. Being zero, it did not pass the ASSERT in the render function, so it was not rendered. commit 805621a9ba1bbf88c1b249d43482959ff8288713 Author: Abdullah Tahiri <email@example.com> Date: Sun Aug 24 09:12:11 2014 +0200 Sketcher visualization enhancement: Do not group sketcher symmetry icons. Do not add a symmetry constraint icon to a group of icons, so that it lies on the line or point providing the symmetry (symmetry axis/point), as it is more clear to the user which line this is. commit 81d0b11ff2f5cd6d854b868a80658fea2f6b17b4 Author: Abdullah Tahiri <firstname.lastname@example.org> Date: Sat Aug 23 06:30:48 2014 +0200 Sketcher feature enhancement: Symmetry constraint perpendicular to axis of symmetry Solves Mantis ticket: http://www.freecadweb.org/tracker/view.php?id=1623 Unrelated minor fix: remove unused variable
Thanks for all your work Abdullahabdullah wrote:I have prepared a new branch rebased to today's master, including 4 commits. I have squashed everything to this 4 commits so that each separate functionality can be disabled in the future without affecting the others.
Jim, if you are satisfied with the result, you can do the honors and post a Pull request pointing to this thread (and you will get a +1 in your personal challenge of arriving to Werner's and Normand's number of posts ), if not let me know.
To https://github.com/abdullahtahiriyo/Fre ... master.git
* [new branch] sketcher_symmetry_constraint_rebased -> sketcher_symmetry_constraint_rebased