Variable Radius Fillet

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Variable Radius Fillet

Post by dubstar-04 »

ickby wrote:Hello,

2. Storing the values in the document is done via properties. In your case you would have to either create a new one for a type holding a double and a quantity or create two lists, one for the type and the second for the quantity. the first way would be cleaner, but a bit more work.
Stefan
I would prefer to do it properly and add new a property type.

Is there any documentation for the properties or a place in the source where I can see example of the implementation?

EDIT: is this the correct file?

https://github.com/FreeCAD/FreeCAD_sf_m ... operty.cpp
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: Variable Radius Fillet

Post by ickby »

Yes, but for inspiration regardng implementation the standart properties are of more use:
https://github.com/FreeCAD/FreeCAD_sf_m ... andard.cpp

You can also look at how the sketcher implements a custom property list for the constraints:
https://github.com/FreeCAD/FreeCAD_sf_m ... List.h#L40
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Variable Radius Fillet

Post by dubstar-04 »

Is it acceptable to write help text under the tool?

It might be use full to explain to the user how to use the
radii table.
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Variable Radius Fillet

Post by jmaustpc »

dubstar-04 wrote:Is it acceptable to write help text under the tool?

It might be use full to explain to the user how to use the
radii table.
Do you mean something simple like this text in the Part WB Sweep tool?
partsweeptaskhelptext.jpg
partsweeptaskhelptext.jpg (34.37 KiB) Viewed 4900 times

It also can be good idea to put some simple information in the tool tip of the toolbar icon, like Yorik did for Draft Dimensions to remind the user how to get linked Dimensions, although I don't know if in this case that would be appropriate or not.
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Variable Radius Fillet

Post by dubstar-04 »

jmaustpc wrote:
dubstar-04 wrote:Is it acceptable to write help text under the tool?

It might be use full to explain to the user how to use the
radii table.
Do you mean something simple like this text in the Part WB Sweep tool?
partsweeptaskhelptext.jpg

It also can be good idea to put some simple information in the tool tip of the toolbar icon, like Yorik did for Draft Dimensions to remind the user how to get linked Dimensions, although I don't know if in this case that would be appropriate or not.
Yes some text like that would help a lot.

What do you mean linked dimensions?

Thanks,

Dan
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Variable Radius Fillet

Post by jmaustpc »

Hi Dan
dubstar-04 wrote:What do you mean linked dimensions?
A Draft Dimension can be "linked" to an edge (at Draft Dimension construction time)....then any change to the length of that edge will automatically update the Draft Dimension.

Have a look at this file if you like...change the "Length" property value of the Part Box "Cube" from 12mm to some thing else...and watch how the dimension updates....its pretty cool actually :)
DraftDimensionLinkedtoPartBoxEdge.fcstd
(10.79 KiB) Downloaded 137 times
Jim
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Variable Radius Fillet

Post by jmaustpc »

Here is a screen shot of the file in my last post
partboxdraftdimensionlinked.jpg
partboxdraftdimensionlinked.jpg (76.11 KiB) Viewed 4891 times
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Variable Radius Fillet

Post by dubstar-04 »

jmaustpc wrote:Here is a screen shot of the file in my last post
partboxdraftdimensionlinked.jpg

That's pretty cool. One thing I did think would be cool for the radius is showing the points on the screen where the offset is.

Just an idea.
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: Variable Radius Fillet

Post by ickby »

Hey Dan,

out of curiosity, did you made any progress on this?

Stefan
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Variable Radius Fillet

Post by dubstar-04 »

Not made any progress with it recently. I need to learn more about how to use git and get an up to date branch. I will try and get back on it this week.

Thanks for the push.
Post Reply