Links

Discussion about the development of the Assembly workbench.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: Links

Post by DeepSOIC »

Noticed one problem. But I haven't yet re-built your latest advance about selection, so it might be fixed already.

1. Create a Part, Body, Sketch, Pad
2. Create App::Link of Part (I'm using Part-o-magic's link creation button).
3. Hide Part (the link remains visible).
4. Click free space to clear selection. Click the shape (a subshape of Link is selected).
5. Click Part in tree view
expected: link should lose selection; Part should become the only selection.
observed: Part is added to selection, as if I was holding Ctrl.
(use View->Panels->Selection View to see the problem)
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: Links

Post by DeepSOIC »

Almost ported assembly2... Dang. App::Link has LinkPlacement, not Placement. :evil: Why!
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Links

Post by realthunder »

DeepSOIC wrote:Almost ported assembly2... Dang. App::Link has LinkPlacement, not Placement. :evil: Why!
For App::LinkPy, I've just added an attribute named Placement as an alias of LinkPlacement. Will that be enough for Python?
DeepSOIC wrote:Noticed one problem. But I haven't yet re-built your latest advance about selection, so it might be fixed already.
It should have been fixed. But I can still occasionally get stray selection which can't be easily reproduced. So there may still some problem there.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
triplus
Veteran
Posts: 9471
Joined: Mon Dec 12, 2011 4:45 pm

Re: Links

Post by triplus »

DeepSOIC wrote:I was about to roll out a mini assembly workbench based on your App::Link...
Sounds good but:
Maybe porting Assembly2 will be easier, hmm...
+1
Almost ported assembly2...
Pics or it didn't happen! And likely Lattice2 could make heavy use of App::Link?
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: Links

Post by DeepSOIC »

triplus wrote:Pics or it didn't happen! And likely Lattice2 could make heavy use of App::Link?
As I said, I got stuck in LinkPlacement vs Placement and went no further =(
triplus
Veteran
Posts: 9471
Joined: Mon Dec 12, 2011 4:45 pm

Re: Links

Post by triplus »

DeepSOIC wrote:As I said, I got stuck in LinkPlacement vs Placement and went no further =(
C'mon. Out of all places you just can't get stuck in placement! :)
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: Links

Post by DeepSOIC »

triplus wrote:C'mon
Ok, ok...
realthunder wrote:For App::LinkPy, I've just added an attribute named Placement as an alias of LinkPlacement. Will that be enough for Python?
Maybe, I'll try...
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: Links

Post by DeepSOIC »

crash.

1. Open:
assembly2-instance-preset.FCStd
(9.41 KiB) Downloaded 76 times
2. Run:

Code: Select all

App.ActiveDocument.Part_i000.getSubObject("Body")
-> crash

Maybe I need a clean build...
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: Links

Post by DeepSOIC »

clean build, still crashes.

OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.11038 (Git)
Build type: Debug
Branch: (HEAD detached at realthunder/Link)
Hash: 9145cda37f6cdcddfef31f9fda6cfc2f84ccc122
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.0.0
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Links

Post by realthunder »

DeepSOIC wrote:clean build, still crashes
Fixed. Please check. Also, in case you've missed it, I've since modified getSubObject such that it works on plain geo group as well.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
Post Reply