Assembly2 in 0.17 - Mac OS - Can't add new components

Discussion about the development of the Assembly workbench.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
easyw-fc
Veteran
Posts: 3633
Joined: Thu Jul 09, 2015 9:34 am

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by easyw-fc »

kbwbe wrote: Wed Jun 13, 2018 9:16 pm Hello Maurice,

which communication-channel do you prefer to use for more questions and discussion of code ? I do not want to mess threads.
Let's make a new thread... something like "A2+ A2 next generation preview"
Edit: or we could continue the thread here:
https://forum.freecadweb.org/viewtopic.php?f=20&t=29207
I would suggest you to create a github account and there clone A2 and your A2+ branch...
then users/devs could contribute directly to your branch
:)
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by Kunda1 »

Don't mean to hijack this thread further but perhaps if and when a maintainer steps up for assembly2 we could not fork but redirect the repo under the FreeCAD GitHub org umbrella (not sure redirect is the correct verbiage but essentially this action would just redirect users who browse https://github.com/hamish2014/FreeCAD_assembly2/ to https://github.com/FreeCAD/FreeCAD_assembly2 I've seen this done before with another repo on GitHub in a different context. This also copies the whole issue queue open&closed tickets seamlessly from the original repo to the redirected repo)

That way we can administrate the repo to i.e. accept trivial PRs amd such + update the README to reflect the current state of the WB and the alternative efforts that are concurrently occurring asm3 & a2+

Any thoughts on this?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
triplus
Veteran
Posts: 9471
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by triplus »

Kunda1 wrote: Sat Jun 23, 2018 2:28 pm That way we can administrate the repo to i.e. accept trivial PRs amd such + update the README to reflect the current state of the WB and the alternative efforts that are concurrently occurring asm3 & a2+
Somebody first needs to volunteer and to be prepared to do that. Otherwise we would quickly end up with a bunch of modules under FreeCAD umbrella with no active maintainer.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by Kunda1 »

triplus wrote: Sat Jun 23, 2018 2:40 pm
Kunda1 wrote: Sat Jun 23, 2018 2:28 pm That way we can administrate the repo to i.e. accept trivial PRs amd such + update the README to reflect the current state of the WB and the alternative efforts that are concurrently occurring asm3 & a2+
Somebody first needs to volunteer and to be prepared to do that. Otherwise we would quickly end up with a bunch of modules under FreeCAD umbrella with no active maintainer.
easyw-fc wrote:ping
@easyw-fc would you be interested and willing to administrate asm2 WB ?

Edit: moved the discussion to another thread: https://forum.freecadweb.org/viewtopic.php?f=20&t=29432
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
triplus
Veteran
Posts: 9471
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by triplus »

Kunda1 wrote: Sat Jun 23, 2018 10:24 pm @easyw-fc would you be interested and willing to administrate asm2 WB ?
We have been vocal and expressed what would be needed to evolve Assembly 2 story further. As for the rest i guess somebody that feels this is something to get involved in needs to make the next step. Like Roland did in the past. If that won't happen i guess that is OK too and things will likely still evolve to settling solution.
User avatar
easyw-fc
Veteran
Posts: 3633
Joined: Thu Jul 09, 2015 9:34 am

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by easyw-fc »

This A2 WB has an unfortunately story.
Hamish started this WB years ago and many times the WB 'risked' to be included in the main branch because of its utility.
During the years it has been a driving resource for FC imo. If you look at A2 videos on YouTube you will see how many views they got.
Hamish has been requested to change A2 licence to match FC license to be merged. Hamish did changed the license accordingly, but the merge was not done.
Now we have a locked repository without an administrator but still with a lot of people using it.

I can offer my help in coding, but I cannot guarantee to manage the repository. I'm not using A2 as I did once.
Moreover an external repo would not solve this issue imo.

Luckily there is a Dev working on a revamped A2plus ... Then, at least, we can offer to users a new temporary solution...
Everyman
Posts: 4
Joined: Tue May 08, 2018 10:08 am

Re: Assembly2 in 0.17 - Mac OS - Can't add new components

Post by Everyman »

As noted here: https://www.freecadweb.org/tracker/view ... 445#c11461
I have sent a pull request (below) with the suggested edits, which seem to fix the problem for me. But I am not experienced with Assembly2 - so please test before deploying.

https://github.com/hamish2014/FreeCAD_a ... 2/pull/154
Post Reply