Another approach to assembly solver (A2plus)

Discussion about the development of the Assembly workbench.
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Oct 06, 2018 2:39 pm

manuelkrause wrote:
Fri Oct 05, 2018 6:32 pm
kbwbe wrote:
Fri Oct 05, 2018 5:45 pm
manuelkrause wrote:
Fri Oct 05, 2018 5:29 pm
@kbwbe: Please reset my "improve-color..." branch(es) to the current devel-branch.
Hi Manuel,
please find fresh branch "improve-color-import" on github, based on recent "devel" branch.
Thank you very much,
I'd prepare something usable for github, during tomorrow. I just want to be sure on here, before you gonna test it.
Then I'd post a PR.
@kbwbe: Hi Klaus,
finally I managed to get the code changes to my github and the PR is on the way.
Please test it and review the code for mistakes, TIA!
@Turro75 and @WandererFan I want to invite you, too, to test and review.
I really hope this thing is working for you as well as it's working on my system here.

Best regards
Turro75
Posts: 166
Joined: Mon Aug 15, 2016 10:23 pm

Re: Another approach to assembly solver (A2plus)

Postby Turro75 » Sat Oct 06, 2018 4:41 pm

Thanks to Paul Randall for a2+ tutorial on Youtube

https://youtu.be/mnkecA9S7kc
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Oct 06, 2018 4:56 pm

Hi guys and girls,
I have forgotton to promote my reworked "improve-color-import" enhancement with some advertisement.
(https://github.com/ManuelKrause/A2plus/ ... lor-import and maybe soon in the same branch @kbwbe's github)

What has changed:
- reordered several functions and 'streamlined' their use in the calling functions
- removed several things that aren't needed after recent viewProvider rework by @WandererFan
- different to the approach in Issue #96 it is able to preserve single face colors (thanks to @Turro75's inspiration)

What's still in:
- the ability to use property "update Colors" == False to get changed colors&transparency from a sub-assembly and NOT reload it from the sub-assembly's source (this may be useful to emphasize specific sub-assemblies)
- many debug info with A2P_DEBUG_3 (we likely want to furtherly reduce them after enough testing)

TIA for testing and providing feedback!

P.S.: I'm not sure whether the single-face color&transparency take-over survives more sub-assembly stages.
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Oct 06, 2018 5:31 pm

Turro75 wrote:
Sat Oct 06, 2018 4:41 pm
Thanks to Paul Randall for a2+ tutorial on Youtube

https://youtu.be/mnkecA9S7kc
@Turro75:
Thank you for sharing your finding! This also gives the chance to improve A2plus.
ATM, I'm not lucky about his workflow. Meaning, to throw in all things at first, without at least some first ordered positioning. Thank you guys, that you've teached me that point already! No wonder that some planes in his assembly were tricky to select.

But in fact it's a great proof of A2plus' value!
User avatar
Kunda1
Posts: 5205
Joined: Thu Jan 05, 2017 9:03 pm

Re: Another approach to assembly solver (A2plus)

Postby Kunda1 » Sat Oct 06, 2018 6:26 pm

Is there an A2plus FC wiki page?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
triplus
Posts: 8605
Joined: Mon Dec 12, 2011 4:45 pm

Re: Another approach to assembly solver (A2plus)

Postby triplus » Sat Oct 06, 2018 6:45 pm

kbwbe wrote:
Fri Oct 05, 2018 8:27 pm
the solver of A2plus is not using NumPy. It uses FC's Vector+Placement Interfaces for Python.
Thanks for the answer.
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Oct 06, 2018 6:48 pm

Kunda1 wrote:
Sat Oct 06, 2018 6:26 pm
Is there an A2plus FC wiki page?
At the moment of writing there's only the information from the bottom of README.MD in https://github.com/kbwbe/A2plus#usage-o ... -workbench, but that's explaining most things that aren't self-explaining after mouse-over the particular WB icon.
Of course we gonna refresh this doc, to reflect the improvements of the last weeks' development.

IMO, this A2plus WB is so easily usable, that there is no need to have a wiki. (This would be one to lead FC user's hand.)
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Oct 06, 2018 9:26 pm

@kbwbe:
I've reworked the README.MD, but cannot push it atm.
On here it looks o.k.
Please take it in in a different way:
Attachments
A2plus.color-improvement-NEW.3.diff.txt
README additions
(3.85 KiB) Downloaded 11 times
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sun Oct 07, 2018 12:22 pm

manuelkrause wrote:
Sat Oct 06, 2018 9:26 pm
@kbwbe:
I've reworked the README.MD, but cannot push it atm.
On here it looks o.k.
Please take it in in a different way:
@kbwbe:
I've described it wrong last night. I wasn't able to create a new separate PR as long as the first one is pending. The proper github usage is still a challenge for me...
So, now, in my github you'd find the uploaded changes to the README.MD. (https://github.com/ManuelKrause/A2plus/ ... lor-import)

Unfortunately I've noticed some typos today, that I haven't fixed yesterday:

Code: Select all

Duplicate part (hold Shift for multiple)- Adds one or more previously imported part into assembly
-> Duplicate part (hold Shift for multiple) - Adds one or more previously imported part into assembly
(missed one whitespace)

Create or refresh simple shape of complete assembly - The newly created compound can be found in tree vies
-> Create or refresh simple shape of complete assembly - The newly created compound can be found in tree view
(typo s -> w)
And maybe some capital letters aren't used correctly ...
kbwbe
Posts: 854
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sun Oct 07, 2018 5:02 pm

manuelkrause wrote:
Sun Oct 07, 2018 12:22 pm
Hi Manuel,
thank you very much for your PR. I merged it to your corresponding branch "improve-color-import" within my repo and just tested it.

Unfortunately i encountered graphical artifacts when importing a subassembly to the main assembly. As there where always problems with parts form old FC versions, i created everything new with FC0.17. But i cannot get rid of the problem.

Please see screenshot here:
.
Main-Assy.png
Main-Assy.png (167.95 KiB) Viewed 182 times
.
Please find all files attached. I hope you can open them this time, as they are completely new.
Please test, whether you are able to import two times "Links-VII-FC17" to a main assembly and link them by plane faces. I did not success.
With recent devel branch, it works. :?
Attachments
Main-Assy-Links-VII.fcstd
(12.23 KiB) Downloaded 7 times
Links-VII-FC17.fcstd
(20.95 KiB) Downloaded 7 times
link-FC17.fcstd
(8.83 KiB) Downloaded 9 times
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM