Another approach to assembly solver (A2plus)

Discussion about the development of the Assembly workbench.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Post by manuelkrause »

roerich_64 wrote: Thu Mar 14, 2019 7:39 am Houston, we have a 'problem'...
Hi, Walter,
when replying to @kbwbe's question above, can you please add one additional info about the part with the artefacts?:

Are the Faces with the artefacts highlighting correctly at mouse-over and/or selecting them?

TIA and BR
Manuel
User avatar
roerich_64
Veteran
Posts: 1465
Joined: Thu May 21, 2015 7:00 pm
Location: Ostfriesland

Re: Another approach to assembly solver (A2plus)

Post by roerich_64 »

Hi Klaus,

Thank for fixing.

I am with the nose on new versions of A2 Plus ;)
every versions i tested in the past has this issue.
Transparency_III.jpg
Transparency_III.jpg (459.85 KiB) Viewed 1708 times
I gave all the Parts a little distance... But it helps not.

It would be nice, i could send it to you... but this assembly is huge,.

So we need a automatic collect mechanism in a2plus to save such big assemblies in a ZIP.
It should also be a great tool for together working teams. ;)

@ Manuel:
In this print screen you can not see the mouse, but it is over the orange face. This face is then ok. The others not...
When i leave them, it is bad :roll:
Transparency_IV.jpg
Transparency_IV.jpg (129.29 KiB) Viewed 1708 times
BR
Walter

p.s. what is 'TIA' ? :?
Die Liebe wird siegen, denn sie ist unzerstörbar :) ;)
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Post by manuelkrause »

roerich_64 wrote: Thu Mar 14, 2019 4:42 pm @ Manuel:
In this print screen you can not see the mouse, but it is over the orange face. This face is then ok. The others not...
When i leave them, it is bad :roll:
Transparency_IV.jpg

BR
Walter

p.s. what is 'TIA' ? :?
Hi, Walter,

thank you very much for your further testing! When I'm counting correctly, this _always_ happens with a 3rd degree assembly? (Counting: (1st) imported part to a first assembly = o.k.; (2nd) first assembly imported to second assembly = o.k.; (3rd) second assembly imported to third-higher assembly = FAIL?). Correct me when I'm wrong.

Due to time limitations I wasn't able to go back too many A2plus releases to pin-point it to a particular one. IMHO, it's more useful to go with the current code, which has highly improved in the recent weeks, and fix the culprit in the new.

The use of distances between the affected parts has no real effect. This hint has been around here, but isn't true for assemblies with more parts/ subassemblies with mixed different full-color, transparent and/or both shaped faces. From my testing, the artifacts come up when one full colored (non-transparent) assembly is joined with an assembly which has transparent parts in it. At least @kbwbe managed with his recent updates to keep such faces selectable, what is a great effort, what I wasn't able to achieve for months.

Currently I'm trying to reproduce your scenario with some simpler parts and some debugging code in A2plus.

TIA means 'Thanks in advance',
BR
Manuel
m.cavallerin
Posts: 115
Joined: Wed May 30, 2018 6:59 pm

Re: Another approach to assembly solver (A2plus)

Post by m.cavallerin »

Hi,

can't remember what was before v0.4.5; but now, if I select the magnifying glass to look over a constrain, the only way to restore opacity to whole assembly, I have to perform:

1 - magnifying glass (start)
2 - show only selected items (apply)
3 - toggles transparency (apply)
4 - show only selected items (remove)
5 - toggles transparency (remove)

All of that because the magnifying glass becomes inactive after step 1.

Is it the same for others?

Thx

Michele

OS: Linux Mint 19
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16085 (Git)
Build type: Release
Branch: master
Hash: 6323069cbbda5ac71dff073f15cc632d8a1f3ea3
Python version: 2.7.15rc1
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Post by manuelkrause »

m.cavallerin wrote: Thu Mar 14, 2019 6:00 pm Hi,

can't remember what was before v0.4.5; but now, if I select the magnifying glass to look over a constrain, the only way to restore opacity to whole assembly, I have to perform:

1 - magnifying glass (start)
2 - show only selected items (apply)
3 - toggles transparency (apply)
4 - show only selected items (remove)
5 - toggles transparency (remove)

All of that because the magnifying glass becomes inactive after step 1.

Is it the same for others?

Thx

Michele

OS: Linux Mint 19
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16085 (Git)
Build type: Release
Branch: master
Hash: 6323069cbbda5ac71dff073f15cc632d8a1f3ea3
Python version: 2.7.15rc1
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
I don't get the magnifying glass available until the constraint is picked in the tree view. And then toggleTransparency isn't selectable for me until this constraint observation has ended. (openSUSE-Tumbleweed on here.)
m.cavallerin
Posts: 115
Joined: Wed May 30, 2018 6:59 pm

Re: Another approach to assembly solver (A2plus)

Post by m.cavallerin »

manuelkrause wrote: Thu Mar 14, 2019 6:41 pm
I don't get the magnifying glass available until the constraint is picked in the tree view. And then toggleTransparency isn't selectable for me until this constraint observation has ended. (openSUSE-Tumbleweed on here.)
Just to be sure we're saying the same thing:
If I select a constrain and then I "highLigths both constrain parts", the "toggle Transparency" is not available until I perform steps from 2 to 4 as for my previous comment...and the "highLigths both constrain parts" is not available too.
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Post by manuelkrause »

m.cavallerin wrote: Thu Mar 14, 2019 7:23 pm
manuelkrause wrote: Thu Mar 14, 2019 6:41 pm
I don't get the magnifying glass available until the constraint is picked in the tree view. And then toggleTransparency isn't selectable for me until this constraint observation has ended. (openSUSE-Tumbleweed on here.)
Just to be sure we're saying the same thing:
If I select a constrain and then I "highLigths both constrain parts", the "toggle Transparency" is not available until I perform steps from 2 to 4 as for my previous comment...and the "highLigths both constrain parts" is not available too.
What magnifying glass do you mean then? Do you talk about A2plus or something from another WB? (This shouldn't sound offensive, I just don't get the point ATM... :-( )
m.cavallerin
Posts: 115
Joined: Wed May 30, 2018 6:59 pm

Re: Another approach to assembly solver (A2plus)

Post by m.cavallerin »

This shouldn't sound offensive, I just don't get the point ATM... :-(
Don't worry

Yes I mean the red one from A2Plus
Attachments
Screenshot from 2019--14 20-43-26.png
Screenshot from 2019--14 20-43-26.png (5.43 KiB) Viewed 1668 times
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Post by manuelkrause »

roerich_64 wrote: Thu Mar 14, 2019 4:42 pm
kbwbe wrote: Thu Mar 14, 2019 2:36 pm
Hi Walter and Klaus,

I've furtherly tried to debug the transparency issue with added message output at critical points.
For the current A2p code ALL color transactions are safe, themselves: In topomapper, MuxAssembly and importPart. Regarding the proof, that they all ship correct values from the calling functions to the following ones. I've tested up to 5th level with different subassembly consistancy/ies.

My only idea for the transparency artefacts is, that we somewhere don't make use of the new transparency-switch actualization workarounds, @kbwbe had introduced recently. As they work fine in several cases, maybe we just missed one or two places to apply them as well?! Or, do we again have some "diffuseColor comes at last" issue somewhere? @kbwbe?

BR
Manuel
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Post by manuelkrause »

m.cavallerin wrote: Thu Mar 14, 2019 7:46 pm
This shouldn't sound offensive, I just don't get the point ATM... :-(
Don't worry

Yes I mean the red one from A2Plus
O.k. or not o.k., that's the question:
For me, these your mentioned steps are exclusive on here:
* pick the made constraint in tree-view: able to view associated parts by clicking magnifying lens (transparency of 80% applies then anyway) & NO toggleTransparency icon available
* none picked: toggleTransparency works

Please correct me if I did get something wrong. I just can't reproduce it on here for now.
Post Reply