Another approach to assembly solver (A2plus)

Discussion about the development of the Assembly workbench.
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Tue Mar 19, 2019 8:34 pm

detlet wrote:
Tue Mar 19, 2019 6:23 pm
I don't know if I got you right here, so I attach the "broken" file.
Please see first screenshot of file "incorrect-cut.fcstd"
Part WB cut is applied to Pad and Revolution, which are inside of bodies. This is not allowed and you get the message "Part::Cut: Links go out of allowed scope". A2plus will not import this cut correctly.
.
incorrect-cut.png
incorrect-cut.png (127.37 KiB) Viewed 1027 times
.
Please see second screenshot of file "correct-cut.fdstd".
Part WB cut is applied to Body and Body001. There is no error written to console and this is ok. A2plus imports it fine...
.
correct-cut.png
correct-cut.png (108.02 KiB) Viewed 1027 times
.
I attach both files. I hope this helps to explain the difference.
Attachments
incorrect-cut.FCStd
(23.23 KiB) Downloaded 9 times
correct-cut.FCStd
(23.33 KiB) Downloaded 10 times
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
User avatar
detlet
Posts: 82
Joined: Sun Sep 25, 2011 5:54 pm
Location: Lauenstein, Germany

Re: Another approach to assembly solver (A2plus)

Postby detlet » Wed Mar 20, 2019 4:18 pm

kbwbe wrote:
Tue Mar 19, 2019 8:34 pm
Hi,
now I got it. Thank you! There remains a question, that is most probably wrong here :D : If the kind of cut I made is wrong and the result not allowed, why is it not prevented by FreeCAD, even if FreeCAD detects the error? Or is there a reasonable use case for the wrong way? For me it would be very helpful if such thing where prevented, because I _never_ open the report view.
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Wed Mar 20, 2019 4:51 pm

detlet wrote:
Wed Mar 20, 2019 4:18 pm
kbwbe wrote:
Tue Mar 19, 2019 8:34 pm
Hi,
now I got it. Thank you! There remains a question, that is most probably wrong here :D : If the kind of cut I made is wrong and the result not allowed, why is it not prevented by FreeCAD, even if FreeCAD detects the error? Or is there a reasonable use case for the wrong way? For me it would be very helpful if such thing where prevented, because I _never_ open the report view.
IMHO, the Part WB should throw a visible Error Message window for this case.

I'm thankful for @kbwbe's guidance on how to make it right. And I hope to remember it in future.

Manuel
User avatar
detlet
Posts: 82
Joined: Sun Sep 25, 2011 5:54 pm
Location: Lauenstein, Germany

Re: Another approach to assembly solver (A2plus)

Postby detlet » Wed Mar 20, 2019 6:09 pm

Hi,
I hope that I don't bug you. But I have the next issue.

It seems to me that sub-assemblies do not like balls / spheres. If I have an assembly which contains a ball, where it doesn't matter if it is a Part ball or a handish made PartDesign one, and I include this assembly into an other assembly, the sub-assembly will lose it's colors. If in the sub-assembly the ball is made invisible, after saving and recalculating the master-assembly the visible parts of the sub-assembly will get theirs colors back.

I've attached a very simple example with a bush and a ball

the ball this time made with PartDesign
ball-a2plus.FCStd
(10.99 KiB) Downloaded 14 times

the master assembly
ball-a2plus-ass.FCStd
(8.75 KiB) Downloaded 14 times

and the sub-assembly
ball-a2plus-sub.FCStd
(9.84 KiB) Downloaded 14 times

Cheers, detlef
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Wed Mar 20, 2019 9:48 pm

detlet wrote:
Wed Mar 20, 2019 6:09 pm
I hope that I don't bug you.
Joke: Yes you do ! ;) Joke left aside: You have found a bug ! :?

I did first test. I did not only miss the correct colors, i also missed the complete ball at second level import. It has to to with number of faces == 1 for a ball. When i created a drill hole within the ball, it has more than one face and it appears with correct colors.

I will look for that tomorrow.
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Thu Mar 21, 2019 10:39 am

detlet wrote:
Wed Mar 20, 2019 6:09 pm
It seems to me that sub-assemblies do not like balls / spheres.
This should be fixed with version V0.4.7. Please update your A2plus WB.
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
User avatar
detlet
Posts: 82
Joined: Sun Sep 25, 2011 5:54 pm
Location: Lauenstein, Germany

Re: Another approach to assembly solver (A2plus)

Postby detlet » Thu Mar 21, 2019 5:53 pm

kbwbe wrote:
Thu Mar 21, 2019 10:39 am
This should be fixed with version V0.4.7. Please update your A2plus WB.
Hi,
works also with an other assembly from me. Tank you for the fast fix!
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sun Mar 24, 2019 1:42 pm

Hi guys,

a new version of A2plus is out: V0.4.10 .

Some small things are new:

- The part labels from the tree view can be displayed in the 3D view
(useful for a quick documentation of an assembly via screenshot + partslist)
This are the new buttons:
New-Buttons.png
New-Buttons.png (2.71 KiB) Viewed 688 times
.
- improved pointOnPlane constraint: As point definition a sphere (it's center) can be used.
- improved pointOnLine constraint: As point definition a sphere can be used and as line definition an axis of a cylinder.
(This allows more constraining to spheres)
.
Improvements-V0.4.10.png
Improvements-V0.4.10.png (163.25 KiB) Viewed 688 times
.
Have fun !
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
Turro75
Posts: 166
Joined: Mon Aug 15, 2016 10:23 pm

Re: Another approach to assembly solver (A2plus)

Postby Turro75 » Mon Mar 25, 2019 7:55 pm

kbwbe wrote:
Sun Mar 24, 2019 1:42 pm
Hi guys,

a new version of A2plus is out: V0.4.10 .

Some small things are new:

- The part labels from the tree view can be displayed in the 3D view
(useful for a quick documentation of an assembly via screenshot + partslist)
Hello Klaus!

very good, would it make sense taking the label text from a specific column from parts list spreadsheet?

Regards

Valerio
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Mon Mar 25, 2019 9:51 pm

Turro75 wrote:
Mon Mar 25, 2019 7:55 pm
Hi Turro,
i am very pleased to hear you after some time.

Obviously i did not think about this topic deep enough, as it was working according to my common working style. (and unfortunately not for others who are working differently)

Doing my way is:
- filename = part's ID number (i manage my parts by a data base)
- label in tree view = filename (automatically done by A2plus) = part's ID
- label on screen = label in treeview = part's ID

When working this way, someone gets a result like this for example:
.
Labeled-assembly.png
Labeled-assembly.png (162.3 KiB) Viewed 574 times
.
Partslist.png
Partslist.png (28.78 KiB) Viewed 574 times
.
So even there does not exist a partlist at time of labeling, i could identify the parts (and their files) by screen labels.

But as told before, this works but is perhaps not the standard way of documentation for other users.
One method i know from other machinery docs is to use the POS-number of the partslist to be drawn to the assembly. This is also not very difficult to implement. But in this case partslist has to be done before.

The labeling code could be made dependent on condition whether a partslist exists or not. In latter case the position number could be used. Is that what you are looking for ?
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM