Another approach to assembly solver (A2plus)

[manuelkrause]

@kbwbe:
Can you please, with your next commits, fix the wrong "print" without brackets?
And this other one in devel-branch:
-> inconsistent use of tabs and spaces in indentation (a2p_rigid.py, line 172)

@wandererfan:
Thank you for taking care of the visibility of PartContainers!

I've tested it across a chain of subassemblies, and when properly updating imported parts in the intermediate subassemblies everything remains consistent (visible/invisible as selected in the very first .fcstd part).
Very good work indeed, thank you!

Best regards, Manuel

[kbwbe]

Can you please, with your next commits, fix the wrong "print" without brackets?

Did you find false prints in "devel" branch ? If yes, where ?
If you found them in branch "turro-dof-3", then @Turro75 should fix this within his PR's.
Otherwise i have to redo this after each merge.

And this other one in devel-branch:
-> inconsistent use of tabs and spaces in indentation (a2p_rigid.py, line 172)

I fixed it in devel branch...

[manuelkrause]

Can you please, with your next commits, fix the wrong "print" without brackets?

Did you find false prints in "devel" branch ? If yes, where ?
If you found them in branch "turro-dof-3", then @Turro75 should fix this within his PR's.
Otherwise i have to redo this after each merge.

And this other one in devel-branch:
-> inconsistent use of tabs and spaces in indentation (a2p_rigid.py, line 172)

I fixed it in devel branch...

It's line 287 in a2p_importpart.py:
print "imported Object is empty/none"

[kbwbe]

It's line 287 in a2p_importpart.py:
print "imported Object is empty/none"

Fixed in "devel" branch.

[manuelkrause]

Fixed in "devel" branch.

Thank you!
Now I'm only waiting for your fix for "recalculating the refPointsBoundBoxSize when calculating the spincenter"...


(Edited wrong copy/paste)

[manuelkrause]

@kbwbe:
I hope you allow me some nitpicking before going for release...
IMO two points should be fixed therefore:

* Cannot find icon: preferences-a2plus
Group icon for preferences-a2plus is not of size 96x96

* When using "Edit imported part" and the imported part is a subassemby it fails and gives the following in Report view:
Running the Python command 'a2p_editImportedPart' failed:
Traceback (most recent call last):
File "/home/manuel/.FreeCAD/Mod/A2plus/a2p_importpart.py", line 458, in Activated
obj = selection[0]

list index out of range

EDIT:
Sorry, I was too fast...
It does NOT fail!!!
It only spits out the mentioned error message.
/EDIT

Regards

[manuelkrause]

@kbwbe:
Just forget the last point... It only happens, when having another part in the foreground and using "Edit" on a non activated assembly part in Tree view -- what is quite logical.

Sorry for the noise.

[kbwbe]

@kbwbe:
* Cannot find icon: preferences-a2plus
Group icon for preferences-a2plus is not of size 96x96

@wandererfan,
need your help. I do not get the .ui-file working regarding the icon for preferences page. Is there a trick ??

* When using "Edit imported part" and the imported part is a subassemby it fails and gives the following in Report view:
Running the Python command 'a2p_editImportedPart' failed:
Traceback (most recent call last):
File "/home/manuel/.FreeCAD/Mod/A2plus/a2p_importpart.py", line 458, in Activated
obj = selection[0]

list index out of range

This happens, if you try to edit a part but you don't have selected one.
It is fixed on "devel" branch. Now you get a console warning.

[kbwbe]

@Turro75,

i need your help.

How can i do a function like that:

booleanResult = rigid.isFullConstrainedTo(anotherRigid) ?

[Turro75]

@Turro75,

i need your help.

How can i do a function like that:

booleanResult = rigid.isFullConstrainedTo(anotherRigid) ?

The function below does nearly what You need, it checks if tempfixed linked obj fully constraint the rigid.

Code: Select all

def linkedTempFixedDOF(self):
        self.pointConstraints = []
        _dofPos = a2p_libDOF.initPosDOF
        _dofRot = a2p_libDOF.initRotDOF
        self.reorderDependencies()
        if not self.tempfixed:
            if len(self.dependencies) > 0:            
                for x in self.dependencies:
                    if x.dependedRigid.tempfixed:
                        _dofPos, _dofRot = x.calcDOF(_dofPos,_dofRot, self.pointConstraints)
        
        return len(_dofPos) + len(_dofRot)

If return value is 0 , the rigid is fully constrained.

Just be sure that point constraint deps are evaluated as last, reorderdependency does this.

This is taken from a2p_rigid in turro dof 3