Another approach to assembly solver (A2plus)

Discussion about the development of the Assembly workbench.
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sat Dec 15, 2018 2:12 am

@manuelkrause, @herbk

Hi Guys,
thank you really very much for testing. I did not expect so many problems. On my side (Linux Mint 18.3, FC0.17 and FC0.18-daily), everything was working smoothly. So nothing is more worth than broad testing to get software to run. And i am happy that i did not release at to early point. So let's see later what the problems are caused by.
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
herbk
Posts: 1428
Joined: Mon Nov 03, 2014 3:45 pm
Location: Windsbach, Bavarya (Germany)

Re: Another approach to assembly solver (A2plus)

Postby herbk » Sat Dec 15, 2018 7:26 am

Hi Manuel,

that prob with the FC packages at opensuse i know, it's since a some time now... and i use the Appimage - my FC Data shows it. ;)

For that behavier i'm thinking at grafic driver to, but why only here...
Gruß Herbert
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sat Dec 15, 2018 12:38 pm

Hi Herbert,
i downloaded the appimage you are testing and tried to reproduce the problems.

Here is the recent systeminformation:
OS: Linux Mint 18.3 Sylvia
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15403 (Git) AppImage
Build type: Release
Branch: master
Hash: 44e8f9e9bf3b7a93e927c97b19c6d2850fd75f19
Python version: 2.7.6
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)

herbk wrote:
Fri Dec 14, 2018 9:28 pm
After clicking "accept", the new UI stays at the screen,
This is the intended behaviour. All buttons of the new UI are greyed out, because it is waiting for the next selection for constraints geometry.
Doing a new selection, appropiate buttons get activated and you can proceed with defining the next constraint.
herbk wrote:
Fri Dec 14, 2018 9:28 pm
FC and the UI is greyd out. If i close the UI by clicking the X button, the UI closes, but FC stay's greyd out and still dosn't respond.
I cannot reproduce this. Both, FC and "Constraint tool" UI stay responsive for me. If i close the "Constraint Tool" FC is working normal for me.

Do you have some error messages in console output ? Perhaps the program flow is interrupted by some errors and causes this behaviour. In this case it would be good you post me some test files.
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sat Dec 15, 2018 12:45 pm

manuelkrause wrote:
Fri Dec 14, 2018 9:36 pm
In my attached screenshot I wasn't able to flip the direction constraint without heavy complaints.
Please, have a look. I'd add more info if you can't reproduce.
Hi Manuel,
please post the original, not working assembly file. I will test it on new devel branch.
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Dec 15, 2018 2:03 pm

kbwbe wrote:
Sat Dec 15, 2018 12:45 pm
manuelkrause wrote:
Fri Dec 14, 2018 9:36 pm
In my attached screenshot I wasn't able to flip the direction constraint without heavy complaints.
Please, have a look. I'd add more info if you can't reproduce.
Hi Manuel,
please post the original, not working assembly file. I will test it on new devel branch.
Hi Klaus,
it was the first constraint to be created and it didn't work. So, in the attached "assembly" file, please create the first constraint yourself, a 'planesParallel' between the highlighted faces as seen in my previously posted screenshot.

(BTW, I've just retested a 'planeCoincident' with the same faces and that succeeded properly. Maybe that info helps a little to catch the bug?!)

Good luck and best regards! This development step is a really nice one (if working ;-) ), again many thanks for your good ideas and hard work!

Manuel
Attachments
Test-01.A2p-devel-20181214.MK.fcstd
Test assembly without constraints
(6.98 KiB) Downloaded 3 times
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sat Dec 15, 2018 2:40 pm

manuelkrause wrote:
Sat Dec 15, 2018 2:03 pm
it was the first constraint to be created and it didn't work. So, in the attached "assembly" file, please create the first constraint yourself, a 'planesParallel' between the highlighted faces as seen in my previously posted screenshot.
Hi Manuel, this was a good hint. There was a small typo within "planesParallel" constraint and because of this it failed. It is fixed within recent devel branch.
Thank you.
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Dec 15, 2018 4:07 pm

kbwbe wrote:
Sat Dec 15, 2018 2:40 pm
manuelkrause wrote:
Sat Dec 15, 2018 2:03 pm
it was the first constraint to be created and it didn't work. So, in the attached "assembly" file, please create the first constraint yourself, a 'planesParallel' between the highlighted faces as seen in my previously posted screenshot.
Hi Manuel, this was a good hint. There was a small typo within "planesParallel" constraint and because of this it failed. It is fixed within recent devel branch.
Thank you.
Hi Klaus,
I have to thank you. Very quick fix, now it works as it should. :-)

Some additional questions / suggestions about possible improvements:
* After adding via 'Constraint Tool' -> coming to 'Constraint properties' and just closing the sub-window by sub-window-bar's (x) close button, the constraint nevertheless does land in the tree. IMHO this action should discard the attempted constraint (like current 'Delete this constraint' does), or, the constraint should not be written to the tree until the final adjustments and 'Accept' confirmation.
* Would it be possible to allow 3D view manipulation (shifting, zooming, panning) for proper inspection, with the 'Constraint properties' sub-window being open?
* Can you implement some sort of "obvious redundancy" check sooner or later? I know it relies on the user to make one mistake multiple times, but once set constraints shouldn't be allowed again (e.g. I've just created two 'planesParallel' with the same settings and the solver didn't complain).

Best regards,
Manuel
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sat Dec 15, 2018 6:16 pm

manuelkrause wrote:
Sat Dec 15, 2018 4:07 pm
Some additional questions / suggestions about possible improvements:
* After adding via 'Constraint Tool' -> coming to 'Constraint properties' and just closing the sub-window by sub-window-bar's (x) close button, the constraint nevertheless does land in the tree. IMHO this action should discard the attempted constraint (like current 'Delete this constraint' does), or, the constraint should not be written to the tree until the final adjustments and 'Accept' confirmation.
* Would it be possible to allow 3D view manipulation (shifting, zooming, panning) for proper inspection, with the 'Constraint properties' sub-window being open?
Hi Manuel,
those two points are done and inside devel branch now.
Regarding first point: It is not possible anymore to leave the dialog without "accept" or "delete this constraint"
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM
User avatar
manuelkrause
Posts: 442
Joined: Thu Jul 05, 2018 7:16 pm

Re: Another approach to assembly solver (A2plus)

Postby manuelkrause » Sat Dec 15, 2018 7:26 pm

kbwbe wrote:
Sat Dec 15, 2018 6:16 pm
manuelkrause wrote:
Sat Dec 15, 2018 4:07 pm
Some additional questions / suggestions about possible improvements:
* After adding via 'Constraint Tool' -> coming to 'Constraint properties' and just closing the sub-window by sub-window-bar's (x) close button, the constraint nevertheless does land in the tree. IMHO this action should discard the attempted constraint (like current 'Delete this constraint' does), or, the constraint should not be written to the tree until the final adjustments and 'Accept' confirmation.
* Would it be possible to allow 3D view manipulation (shifting, zooming, panning) for proper inspection, with the 'Constraint properties' sub-window being open?
Hi Manuel,
those two points are done and inside devel branch now.
Regarding first point: It is not possible anymore to leave the dialog without "accept" or "delete this constraint"
Hi Klaus,
regarding the latter, I don't know if that's the best solution... But it's working in the right way now, to force the user to take a decision.

The other new changes to your devel-branch do work very well on here. Thanks for taking them into account and implementing so fast.

Mmh, I got another one: Maybe Linux specific: When minimizing the FC window or fetch other programs (browser, smplayer e.g.) to the foreground, the "Constraint Tools" window remains at the top display representation of the desktop (here KDE). IMHO it should reside in the FC display area only. See the funny screenshot below.

Best regards,
Manuel
Attachments
Screenshot_20181215_202212.png
Screenshot_20181215_202212.png (74.42 KiB) Viewed 227 times
kbwbe
Posts: 853
Joined: Tue Apr 10, 2018 3:12 pm
Location: Germany, near Köln (Cologne)

Re: Another approach to assembly solver (A2plus)

Postby kbwbe » Sun Dec 16, 2018 2:48 pm

manuelkrause wrote:
Hi Manuel,
i modified devel branch again.
- Constraint dialog does not stay on top of other active window now
- X-Button (close) of constraint dialog can be used now
Please test again.
herbk wrote:
Hi Herbert,
i think your problem with greyed out FC window has to do something with your X-window manager, which behaves different from mine. As there were a lot of changings within A2plus regarding window management, please test again whether your problem persists. (devel branch)

Thank you Guy's for testing !
KBWBE

https://github.com/kbwbe/A2plus
latest release: v0.4.26b, installable via FreeCAD's addon manager
Tutorials:
Paul Randall: https://youtu.be/mnkecA9S7kc
anisim (deutsch): https://www.youtube.com/watch?v=vDcaFq6IEJM