[Solved]Shape Binder and clone of a object

Discussion about the development of the Assembly workbench.
koluna
Posts: 259
Joined: Thu Sep 20, 2018 12:36 pm

Re: Shape Binder and clone of a object

Postby koluna » Mon Jan 28, 2019 4:46 pm

chrisb wrote:
Mon Jan 28, 2019 3:21 pm
can you upload that a2+ free document?
Yes, I can.
Attachments
Motor part.FCStd
(589.29 KiB) Downloaded 15 times
koluna
Posts: 259
Joined: Thu Sep 20, 2018 12:36 pm

Re: Shape Binder and clone of a object

Postby koluna » Mon Jan 28, 2019 6:37 pm

I forgot to attach an example image. Sorry, see back.

I tried to watch Paul Randal's video. He a cool guy, but he speaks very quickly and I cannot understand him :(
chrisb
Posts: 19604
Joined: Tue Mar 17, 2015 9:14 am

Re: Shape Binder and clone of a object

Postby chrisb » Mon Jan 28, 2019 10:40 pm

I cannot reproduce the issue. If I take your file, create a body, select "Motor Bracket" and add a ShapeBinder to the Body it is in exactly the place where "Motor Bracket is. It works on Ubuntu and MacOS . I would be surprised if it doesn't work on Windows, but someone else should verify.

OS: Ubuntu 16.04.5 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15694 (Git)
Build type: Release
Branch: master
Hash: 96dee91d5e7d7fd37f43a4dcf406a120ae1f1b8a
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

OS: macOS 10.13
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15525 (Git)
Build type: Release
Branch: master
Hash: 1a7d3d9a37fe43468c8ac84590c1db53e2b2000a
Python version: 3.6.7
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)
koluna
Posts: 259
Joined: Thu Sep 20, 2018 12:36 pm

Re: Shape Binder and clone of a object

Postby koluna » Tue Jan 29, 2019 7:10 am

Did You see the video in the first post?
Did You try my "printer" file?
The problem is with the clone of Motor part. The original object is ok.
koluna
Posts: 259
Joined: Thu Sep 20, 2018 12:36 pm

Re: Shape Binder and clone of a object

Postby koluna » Tue Jan 29, 2019 7:30 am

https://yadi.sk/d/jAU4GpkadOS_Cw

See this file, please (it is without any external workbenches).
The Shape Binder for the clone has a wrong orientation and position.
Attachments
shape-0.png
shape-0.png (54.33 KiB) Viewed 298 times
chrisb
Posts: 19604
Joined: Tue Mar 17, 2015 9:14 am

Re: Shape Binder and clone of a object

Postby chrisb » Tue Jan 29, 2019 7:54 am

koluna wrote:
Tue Jan 29, 2019 7:10 am
Did You see the video in the first post?
Did You try my "printer" file?
The problem is with the clone of Motor part. The original object is ok.
I had checked the file "Motor part.FCStd" from your upload. It had no clone. I will have a look at the new file.
User avatar
DeepSOIC
Posts: 7149
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Shape Binder and clone of a object

Postby DeepSOIC » Wed Jan 30, 2019 3:27 pm

I have checked it with the very first (big!) file. There is a problem: if I shapebinder the whole "Left motor part"(Clone004, a Draft Clone), and change "Trace Support" of shapebinder to True, the yellow thing is where it's supposed to be. But if I shapebinder only a face of "Left motor part", the face is somewhere else. If I select two faces, the shapebinder is in yet another place. There's obviously something really buggy in there.
User avatar
DeepSOIC
Posts: 7149
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Shape Binder and clone of a object

Postby DeepSOIC » Wed Jan 30, 2019 3:45 pm

I'll try to fix it in the weekend, but I don't promise.
chrisb
Posts: 19604
Joined: Tue Mar 17, 2015 9:14 am

Re: Shape Binder and clone of a object

Postby chrisb » Wed Jan 30, 2019 5:47 pm

I will try to extract a simple use case. It might be helpful for error search and testing.
chrisb
Posts: 19604
Joined: Tue Mar 17, 2015 9:14 am

Re: Shape Binder and clone of a object

Postby chrisb » Wed Jan 30, 2019 9:57 pm

I have seen this issue twice now and in both cases was assembly involved.

The real problem is not the ShapeBinder, that is in fact shown in the right place, the problem is the clone or an element in the Part container. I have simplified the file a bit further, so that the Part contains only 2 objects. If I delete "GT2 Pulley 20 Teeth" the MotorBracket all of a sudden pops to the position where the ShapeBinder is. The ShapeBinder seems to stay in place only because it is broken due to the now missing face:
beforeDelete.png
beforeDelete.png (11.84 KiB) Viewed 215 times
and afterwards and performing a recompute:
afterDelete.png
afterDelete.png (11.3 KiB) Viewed 215 times
The FreeCAD file attached is the state before delete.
Attachments
test6_cb.FCStd
(339.4 KiB) Downloaded 12 times