Assembly 4 workbench

Discussion about the development of the Assembly workbench.
User avatar
Zolko
Posts: 337
Joined: Mon Dec 17, 2018 10:02 am

Re: Assembly 4 workbench

Postby Zolko » Tue Jul 23, 2019 7:45 am

mfasano wrote:
Mon Jul 22, 2019 5:51 pm
This fixes it.
OK, so I released a bug-fix version 0.5.5

And then, at looking at GitHub, I see that some people made comments, and even proposed code improvements ... and I have no idea how to merge/use them. I did merge one through the web interface of GitHub, but it doesn't appear on my local branch. WTF ?
try the Assembly4 workbench for FreCAD v0.19
installable with Tools > Addon Manager, new version 0.6.3. Simple tutorial here
User avatar
Kunda1
Posts: 5486
Joined: Thu Jan 05, 2017 9:03 pm

Re: Assembly 4 workbench

Postby Kunda1 » Tue Jul 23, 2019 12:54 pm

Zolko wrote:
Tue Jul 23, 2019 7:45 am
mfasano wrote:
Mon Jul 22, 2019 5:51 pm
This fixes it.
OK, so I released a bug-fix version 0.5.5

And then, at looking at GitHub, I see that some people made comments, and even proposed code improvements ... and I have no idea how to merge/use them. I did merge one through the web interface of GitHub, but it doesn't appear on my local branch. WTF ?
Maybe you should consider using Gitkraken, which is a GUI for git. It's proprietary but i use it for open source only. It's very useful to visualize what is going on in a repo. git is a bit convoluted but what you are trying to understand is thankfully not complex git stuff. Feel free to private message me.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
mfasano
Posts: 48
Joined: Wed Apr 11, 2018 12:31 pm

Re: Assembly 4 workbench

Postby mfasano » Mon Aug 12, 2019 1:10 pm

Hello Zolko;

Have you tested Assembly4 for with Realthunders link merge? If you do not want to build it. Maybe you can use this PPA.

https://code.launchpad.net/~kkremitzki/ ... ad-staging
User avatar
Zolko
Posts: 337
Joined: Mon Dec 17, 2018 10:02 am

Re: Assembly 4 workbench

Postby Zolko » Mon Aug 12, 2019 5:54 pm

mfasano wrote:
Mon Aug 12, 2019 1:10 pm
Have you tested Assembly4 for with Realthunders link merge? If you do not want to build it. Maybe you can use this PPA.
Thank-you for the link. I didn't have yet the time to test Asm4 with the Link::Merge, and I'll be offline for a couple of weeks. Cheers
try the Assembly4 workbench for FreCAD v0.19
installable with Tools > Addon Manager, new version 0.6.3. Simple tutorial here
triplus
Posts: 8676
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly 4 workbench

Postby triplus » Fri Aug 16, 2019 11:02 pm

After App::Link oriented PR gets merged hopefully Assembly 4 module will start to work with upstream FreeCAD. And hence people will be able to install it through Addon manager.

That should hopefully increase the (install) success rate.
User avatar
easyw-fc
Posts: 2627
Joined: Thu Jul 09, 2015 9:34 am

Re: Assembly 4 workbench

Postby easyw-fc » Sat Aug 17, 2019 12:26 pm

triplus wrote:
Fri Aug 16, 2019 11:02 pm
After App::Link oriented PR gets merged hopefully Assembly 4 module will start to work with upstream FreeCAD. And hence people will be able to install it through Addon manager.

That should hopefully increase the (install) success rate.
Not enough.. it will need also Expressions.
triplus
Posts: 8676
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly 4 workbench

Postby triplus » Sun Aug 18, 2019 2:03 pm

If i remember correctly a rather small modification was needed (expression engine) to get it working? In such case i guess that could get upstream too. For the purpose of getting more people involved in Assembly 4 discussions.
User avatar
Zolko
Posts: 337
Joined: Mon Dec 17, 2018 10:02 am

Re: Assembly 4 workbench

Postby Zolko » Sun Aug 25, 2019 1:13 pm

easyw-fc wrote:
Sat Aug 17, 2019 12:26 pm
Not enough.. it will need also Expressions.
good point, yes

triplus wrote:
Sun Aug 18, 2019 2:03 pm
If i remember correctly a rather small modification was needed (expression engine) to get it working?
yes-and-no: Asm4 uses the extended ExpressionEngine that is included as standard in realthunder's asm3 branch, no modifications needed. But we probably can't use the ExpressionEngine that comes as standard in v0.19-pre, I don't yet know whether realthunder has included that in his PR. I have to check.

But I'm also thinking about another way for Asm4 that wouldn't need the ExpressionEngine at all. And that could lead to a future merge of Asm2+ and Asm4, by using the Asm2+ solver with the Asm4 assembly structure. We'll have to discuss that.
try the Assembly4 workbench for FreCAD v0.19
installable with Tools > Addon Manager, new version 0.6.3. Simple tutorial here
User avatar
fosselius
Posts: 344
Joined: Sat Apr 23, 2016 10:03 am

Re: Assembly 4 workbench

Postby fosselius » Sun Aug 25, 2019 2:24 pm

To include Link support in ASM2+ has been discussed earlier, The conclusion was that support for link should be implemented when Link got merged. so soon ish ;)
triplus
Posts: 8676
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly 4 workbench

Postby triplus » Sun Aug 25, 2019 10:32 pm

Zolko wrote:
Sun Aug 25, 2019 1:13 pm
We'll have to discuss that.
Yes.