[ToDo]fix / pull request for polar pattern around datum line

Discussion about the development of the Assembly workbench.
tmoore
Posts: 8
Joined: Sat Mar 01, 2014 11:44 pm
Location: Bordeaux, France
Contact:

[ToDo]fix / pull request for polar pattern around datum line

Postby tmoore » Fri Apr 18, 2014 8:48 am

Following the discussion in viewtopic.php?f=3&t=6307 I tried making a polar pattern around a datum line in the newly-updated assembly branch. It *almost* worked: during the polar pattern dialog the proper results are displayed, but confirming the dialog throws an error and the polar pattern feature cannot be created. It turns out that the wrong object was stored as the axis. https://github.com/timoore/FreeCAD_sf_m ... 616301553e fixes this bug; please pull and apply to jriegel/dev-assembly.

With this patch I can model the cylinder holes in my crankcase as a polar pattern rotated around the X-axis without creating any helper solid geometry, which I think is great!

Tim
User avatar
jriegel
Site Admin
Posts: 3369
Joined: Sun Feb 15, 2009 5:29 pm
Location: Ulm, Germany
Contact:

Re: fix / pull request for polar pattern around datum line

Postby jriegel » Tue Apr 22, 2014 7:50 am

Ok, I will take a Look
Stop whining - start coding!
User avatar
bejant
Posts: 5940
Joined: Thu Jul 11, 2013 3:06 pm

Re: [ToDo]fix / pull request for polar pattern around datum

Postby bejant » Tue Apr 22, 2014 6:25 pm

Now cross-referenced to issue #1511.