It seems that kkremitzki did not read thisjmaustpc wrote: ↑Sun Jul 23, 2017 1:11 am kkremitzki wrote: ↑
Sun Jul 23, 2017 12:53 am
I created a namespace in the wiki for 0.17, so new copies of these pages can be set up or transferred from the sandbox.
For example structure, see:
https://freecadweb.org/wiki/0.17
https://freecadweb.org/wiki/0.17:PartDesign
https://freecadweb.org/wiki/0.17:PartDesign/Revolution
As I said above, I think that's a mistake, if we have to make new pages then the new pages should be for the legacy page ...not the new page that should be the default.
We were typing our posts at the same time.
PartDesign Next in wiki
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Veteran
- Posts: 2611
- Joined: Tue Feb 21, 2012 8:07 pm
- Location: Torino - Italy
Re: PartDesign Next in wiki
-
- Veteran
- Posts: 2611
- Joined: Tue Feb 21, 2012 8:07 pm
- Location: Torino - Italy
Re: PartDesign Next in wiki
If I understand correctly, we must do as it was done for Spreadsheet Workbench and Spreadsheet_legacy when we moved to the new version. The existing page is the page to be adapted to version 0.17. The content of page 0.16 is transferred to a Legacy page.jmaustpc wrote: ↑Sun Jul 23, 2017 1:08 am It's important to remember that overtime only 0.17 and beyond, is important. So I don't like the idea of creating a new page for what will soon enough be the correct page. If we need to have a different page then I would move the current data to a "legacy" page, make the default current page 0.17, but with a prominent note at the top directing the 0.16 users to the legacy page.
100% agree.
Renato
Re: PartDesign Next in wiki
Yes, that is what I mean.renatorivo wrote: ↑Sun Jul 23, 2017 9:28 pmIf I understand correctly, we must do as it was done for Spreadsheet Workbench and Spreadsheet_legacy when we moved to the new version. The existing page is the page to be adapted to version 0.17. The content of page 0.16 is transferred to a Legacy page.jmaustpc wrote: ↑Sun Jul 23, 2017 1:08 am It's important to remember that overtime only 0.17 and beyond, is important. So I don't like the idea of creating a new page for what will soon enough be the correct page. If we need to have a different page then I would move the current data to a "legacy" page, make the default current page 0.17, but with a prominent note at the top directing the 0.16 users to the legacy page.
100% agree.
Renato
-
- Veteran
- Posts: 2611
- Joined: Tue Feb 21, 2012 8:07 pm
- Location: Torino - Italy
Re: PartDesign Next in wiki
created
https://www.freecadweb.org/wiki/PartDesign_legacy Copy of the current PartDesignWB
https://www.freecadweb.org/wiki/Sandbox ... _Workbench Candidate for PartDesignWB0.17, where to make all the changes before publishing
Next steps
- Have the approval of what has been done
- Adapt texts for FreeCAD 0.17. (Someone who is native English)
- Sort the tools for groups and create their templates
- Create pages for new tools. Verify that the page names match the name of the commands. Thank you
- Create legacy pages for 0.16 tools. (If necessary, otherwise add only the appropriate notes)
-....
Renato
https://www.freecadweb.org/wiki/PartDesign_legacy Copy of the current PartDesignWB
https://www.freecadweb.org/wiki/Sandbox ... _Workbench Candidate for PartDesignWB0.17, where to make all the changes before publishing
Next steps
- Have the approval of what has been done
- Adapt texts for FreeCAD 0.17. (Someone who is native English)
- Sort the tools for groups and create their templates
- Create pages for new tools. Verify that the page names match the name of the commands. Thank you
- Create legacy pages for 0.16 tools. (If necessary, otherwise add only the appropriate notes)
-....
Renato
-
- Veteran
- Posts: 2611
- Joined: Tue Feb 21, 2012 8:07 pm
- Location: Torino - Italy
Re: PartDesign Next in wiki
Please check the setting for the https://www.freecadweb.org/wiki/Sandbox ... _Workbench page. I copied from links to the forum. Correct what you do not like.
Re: PartDesign Next in wiki
Looks good in general. Should we begin adding information to the missing (red) wiki pages as well?
Would it be convenient to make a copy of the current PD documentation and migrate it to the _Legacy pages at this moment?
Would it be convenient to make a copy of the current PD documentation and migrate it to the _Legacy pages at this moment?
Need help? Feel free to ask, but please read the guidelines first
-
- Veteran
- Posts: 2611
- Joined: Tue Feb 21, 2012 8:07 pm
- Location: Torino - Italy
Re: PartDesign Next in wiki
What is the exact name of the commands included in the groups << "PartDesign_CompPrimitiveAdditive" and << "PartDesign_CompPrimitiveSubtractive"?
Or where can I find them?
Thank you. Renato
Or where can I find them?
Thank you. Renato
Re: PartDesign Next in wiki
-
- Veteran
- Posts: 2611
- Joined: Tue Feb 21, 2012 8:07 pm
- Location: Torino - Italy
Re: PartDesign Next in wiki
Thanks triplus, but it is not this.
I look for PartDesignNext commands.
I've found a few names in https://github.com/FreeCAD/FreeCAD/blob ... kbench.cpp , but some names are missing, those that are grouped in PartDesign_CompPrimitiveAdditive. I also looked in https://github.com/FreeCAD/FreeCAD/blob ... mitive.cpp
I think the names are: "PartDesign_AdditiveBox", "PartDesign_AdditiveCone", ....."PartDesign_SubtractiveBox", "PartDesign_SubtractiveCone", ....., but I'm not sure.
It seems these actions (AdditiveBox, AdditiveCone, ...) do not have a direct command, but they are subcommands. In this case I do not create a wiki page for each of them, but I put it all together in a single page with the name "PartDesign_CompPrimitiveAdditive" and "PartDesign_CompPrimitiveSubtractive".
Renato
I look for PartDesignNext commands.
I've found a few names in https://github.com/FreeCAD/FreeCAD/blob ... kbench.cpp , but some names are missing, those that are grouped in PartDesign_CompPrimitiveAdditive. I also looked in https://github.com/FreeCAD/FreeCAD/blob ... mitive.cpp
I think the names are: "PartDesign_AdditiveBox", "PartDesign_AdditiveCone", ....."PartDesign_SubtractiveBox", "PartDesign_SubtractiveCone", ....., but I'm not sure.
It seems these actions (AdditiveBox, AdditiveCone, ...) do not have a direct command, but they are subcommands. In this case I do not create a wiki page for each of them, but I put it all together in a single page with the name "PartDesign_CompPrimitiveAdditive" and "PartDesign_CompPrimitiveSubtractive".
Renato
Re: PartDesign Next in wiki
Hi Renato.
Yes you are correct. Currently individual commands listed under Additive/Subtractive menu have no command name set. As you will need to use some name i feel best to use the name of the icon (as it is aligned with how FreeCAD commands are named in general):
PartDesign_Additive_Box
PartDesign_Additive_Cylinder
PartDesign_Additive_Sphere
PartDesign_Additive_Cone
PartDesign_Additive_Ellipsoid
PartDesign_Additive_Torus
PartDesign_Additive_Prism
PartDesign_Additive_Wedge
PartDesign_Subtractive_Box
PartDesign_Subtractive_Cylinder
PartDesign_Subtractive_Sphere
PartDesign_Subtractive_Cone
PartDesign_Subtractive_Ellipsoid
PartDesign_Subtractive_Torus
PartDesign_Subtractive_Prism
PartDesign_Subtractive_Wedge
I will wait a bit to see if any additional info will be provided. After i can create a pull request (likely over the weekend) and i will use the same names set for object name). That will make the commands available in modules like PieMenu, CommandPanel, IconThemes ... And likely when using What's This (Shift + F1) command will work as long as the corresponding help files are provided. And AFAIK help files are created from the Wiki and that is why it is important the command names exist and are in sync between the code and the Wiki?
Yes you are correct. Currently individual commands listed under Additive/Subtractive menu have no command name set. As you will need to use some name i feel best to use the name of the icon (as it is aligned with how FreeCAD commands are named in general):
PartDesign_Additive_Box
PartDesign_Additive_Cylinder
PartDesign_Additive_Sphere
PartDesign_Additive_Cone
PartDesign_Additive_Ellipsoid
PartDesign_Additive_Torus
PartDesign_Additive_Prism
PartDesign_Additive_Wedge
PartDesign_Subtractive_Box
PartDesign_Subtractive_Cylinder
PartDesign_Subtractive_Sphere
PartDesign_Subtractive_Cone
PartDesign_Subtractive_Ellipsoid
PartDesign_Subtractive_Torus
PartDesign_Subtractive_Prism
PartDesign_Subtractive_Wedge
I will wait a bit to see if any additional info will be provided. After i can create a pull request (likely over the weekend) and i will use the same names set for object name). That will make the commands available in modules like PieMenu, CommandPanel, IconThemes ... And likely when using What's This (Shift + F1) command will work as long as the corresponding help files are provided. And AFAIK help files are created from the Wiki and that is why it is important the command names exist and are in sync between the code and the Wiki?