Path_3DPocket vs Path_Pocket_3D

Discussions about the wiki documentation of FreeCAD and its translation.
User avatar
Kunda1
Posts: 7094
Joined: Thu Jan 05, 2017 9:03 pm

Path_3DPocket vs Path_Pocket_3D

Postby Kunda1 » Fri Jan 17, 2020 2:30 pm

Can someone explain the difference between these 2 commands please?
Path_3DPocket vs Path_Pocket_3D
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
sliptonic
Posts: 1688
Joined: Tue Oct 25, 2011 10:46 pm

Re: Path_3DPocket vs Path_Pocket_3D

Postby sliptonic » Fri Jan 17, 2020 6:34 pm

Path_Pocket_3D is the correct name.

The only reference to Path_3DPocket in the source are a couple commits related to documentation. I think I created the wiki page with the wrong name and it's still hanging around.
chrisb
Posts: 22578
Joined: Tue Mar 17, 2015 9:14 am

Re: Path_3DPocket vs Path_Pocket_3D

Postby chrisb » Fri Jan 17, 2020 8:35 pm

Watch out when deleting the other page, it has much more contents.
User avatar
Kunda1
Posts: 7094
Joined: Thu Jan 05, 2017 9:03 pm

Re: Path_3DPocket vs Path_Pocket_3D

Postby Kunda1 » Fri Jan 17, 2020 11:37 pm

sliptonic wrote:
Fri Jan 17, 2020 6:34 pm
Path_Pocket_3D is the correct name.

The only reference to Path_3DPocket in the source are a couple commits related to documentation. I think I created the wiki page with the wrong name and it's still hanging around.
@sliptonic do you mind consolidating the page then? I'll delete it once you've completed.

Edit: I'll make any pages pointed at the Path_3DPocket redirected to Path_Pocket_3D.

Edit2: https://www.freecadweb.org/wiki/Special ... h_3DPocket
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
sliptonic
Posts: 1688
Joined: Tue Oct 25, 2011 10:46 pm

Re: Path_3DPocket vs Path_Pocket_3D

Postby sliptonic » Sat Jan 18, 2020 4:04 pm

Path_Pocket_3D updated.
User avatar
Kunda1
Posts: 7094
Joined: Thu Jan 05, 2017 9:03 pm

Re: Path_3DPocket vs Path_Pocket_3D

Postby Kunda1 » Sat Jan 18, 2020 11:05 pm

sliptonic wrote:
Sat Jan 18, 2020 4:04 pm
Path_Pocket_3D updated.
Thanks @sliptonic
Quick questions:
What version was the feature introduced in?
Are there any examples that we can use to illustrate this feature via python script?
Any limitations/known issues ?
Also, is there a screenshot we can add to the page to illustrate what the tool does?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 7094
Joined: Thu Jan 05, 2017 9:03 pm

Re: Path_3DPocket vs Path_Pocket_3D

Postby Kunda1 » Sun Jan 19, 2020 1:00 pm

I've redirected Path_3DPocket to Path_Pocket_3D
but was unable to redirect Path_3DPocket's translation pages. This translation extension is giving me a headache :roll:
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 7094
Joined: Thu Jan 05, 2017 9:03 pm

Re: Path_3DPocket vs Path_Pocket_3D

Postby Kunda1 » Sun Jan 19, 2020 1:41 pm

I'll add this thread to the Wiki subforum for assistance (but keep it linked in Path subforum as well)

Also changing the {{GuiCommand}} name of the page breaks the link to this commands related logo
https://www.freecadweb.org/wiki/File:Path-3DPocket.png

What should I do to fix this? Is there a way to alter https://www.freecadweb.org/wiki/Template:GuiCommand so it looks for the image elsewhere? Or should I make a duplicate of https://www.freecadweb.org/wiki/File:Path-3DPocket.png called "Path-Pocket-3D.png" ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
renatorivo
Posts: 2384
Joined: Tue Feb 21, 2012 8:07 pm
Location: Torino - Italy

Re: Path_3DPocket vs Path_Pocket_3D

Postby renatorivo » Mon Jan 20, 2020 8:49 pm

Kunda1 wrote:
Sun Jan 19, 2020 1:00 pm
I've redirected Path_3DPocket to Path_Pocket_3D
but was unable to redirect Path_3DPocket's translation pages.
Before making these changes, you must remove the page from the translatable ones.
Now you can redirect the translated pages.
User avatar
JoshuaCall
Posts: 44
Joined: Tue Dec 17, 2019 3:43 am

Re: Path_3DPocket vs Path_Pocket_3D

Postby JoshuaCall » Mon Jan 20, 2020 9:13 pm

Kunda1 wrote:
Sun Jan 19, 2020 1:41 pm
Also changing the {{GuiCommand}} name of the page breaks the link to this commands related logo
https://www.freecadweb.org/wiki/File:Path-3DPocket.png

What should I do to fix this? Is there a way to alter https://www.freecadweb.org/wiki/Template:GuiCommand so it looks for the image elsewhere?
You can add an optional icon parameter to the template. I've added a

Code: Select all

Icon=Path-3DPocket.svg
parameter to the gui command template. Vocx might say that's it's better to rename Path-3DPocket.svg in the source code, though.