icons for Path Workbench

Discussions about the wiki documentation of FreeCAD and its translation.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
david69
Veteran
Posts: 1774
Joined: Wed Jan 01, 2014 7:48 pm

icons for Path Workbench

Post by david69 »

here are the missing .svg version

Path_ToolLibraryEdit.png
Path_Simulator.png
Path_DressupDogbone.png
Path_DressupLeadInOut.png
Path_DressupDragKnife.png
Path_DressupRampEntry.png
Path_DressupTag.png
Path_Fixture.png
Path_GcodeFromShape.png --> if we look for Path_GcodeFromShape.svg, we find a use but the drawing is not defined
Path FromShapes.png

for Path_Pocket_3D & Path_Sanity, the description is written like that:

Code: Select all

{{GuiCommand
|Icon=Path-3DPocket.svg
|Name=Path Pocket 3D
|MenuLocation=Path → 3D Pocket
|Workbenches=[[Path_Workbench|Path]]
|Shortcut=
|SeeAlso=
}}
for all other pages, it is following:

Code: Select all

{{GuiCommand
|Name=Path Pocket 3D
|MenuLocation=Path → 3D Pocket
|Workbenches=[[Path_Workbench|Path]]
|Shortcut=
|SeeAlso=
}}
but if you do so, then there is no more icon associated to the name of the tool.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: icons for Path Workbench

Post by Roy_043 »

A couple were already available as SVG. The rest has been added.
david69
Veteran
Posts: 1774
Joined: Wed Jan 01, 2014 7:48 pm

Re: icons for Path Workbench

Post by david69 »

and today, all the following icons
Path_DressupDogbone.png
Path_DressupDragKnife.png
Path_DressupRampEntry.png
Path_DressupLeadInOut.png
Path_DressupRampEntry.png
Path_Fixture.png
Path_GcodeFromShape.png

are receiving the unical icon Path_DressupTag.svg
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: icons for Path Workbench

Post by Roy_043 »

They are not all the same (at least 3 different SVGs for your last list of PNGs). But it is true that there are commands in the Path WB that have the same icon.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: icons for Path Workbench

Post by Roy_043 »

I have updated the PNGs to SVGs now.
david69
Veteran
Posts: 1774
Joined: Wed Jan 01, 2014 7:48 pm

Re: icons for Path Workbench

Post by david69 »

thank you Roy_043.
david69
Veteran
Posts: 1774
Joined: Wed Jan 01, 2014 7:48 pm

Re: icons for Path Workbench

Post by david69 »

Roy_043, as I am applying my changes on the French page, I think you have missed to associate the icon to this page Path_Sanity.

if i remove the |Icon=Path_Sanity.svg from the GuiCommand then we don't have anymore icon on the page.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: icons for Path Workbench

Post by Roy_043 »

The name in the GuiCommand was faulty. This has been fixed now.
david69
Veteran
Posts: 1774
Joined: Wed Jan 01, 2014 7:48 pm

Re: icons for Path Workbench

Post by david69 »

Doooo and I didn't even notice that!
Post Reply