help on sheet metal script
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
Fold sheet metal wall at sketch line.
https://github.com/shaise/FreeCAD_SheetMetal/pull/58
Step to use
1.Select a face to bend 2. Select sketch & Press icon 3.Select inverbend to flip selection side Feedback & grammatical corrections are welcome.
It is based on fillet. so where it fail, this also fail. [unfold not implemented]
https://github.com/shaise/FreeCAD_SheetMetal/pull/58
Step to use
1.Select a face to bend 2. Select sketch & Press icon 3.Select inverbend to flip selection side Feedback & grammatical corrections are welcome.
It is based on fillet. so where it fail, this also fail. [unfold not implemented]
Re: help on sheet metal script
Hi jaisejames,
Very nice indeed!!!
But before I merge it, you need to change the nesting of the folds in the tree view. This is the nesting now: When you are outside a body, this is ok and should look like that, but inside a body this should look different.
All the folds should be one under the other in the same level, and only the sketches are nested under their parent folds.
so more ore less it should look like that (i just edited the image): You can take a look at my view provider for bends to see how I find out if I am under Body or outside a body.
Regarding unfolds, for now the simplest way is that when unfold=true, the function just returns a copy of the base object without doing any k factor calculation. (actually I think K factor should be taken into account in the bend function, not the unfold function in this case, to simulate real bending)
Thanks again!! great work.
shai
Very nice indeed!!!
But before I merge it, you need to change the nesting of the folds in the tree view. This is the nesting now: When you are outside a body, this is ok and should look like that, but inside a body this should look different.
All the folds should be one under the other in the same level, and only the sketches are nested under their parent folds.
so more ore less it should look like that (i just edited the image): You can take a look at my view provider for bends to see how I find out if I am under Body or outside a body.
Regarding unfolds, for now the simplest way is that when unfold=true, the function just returns a copy of the base object without doing any k factor calculation. (actually I think K factor should be taken into account in the bend function, not the unfold function in this case, to simulate real bending)
Thanks again!! great work.
shai
Re: help on sheet metal script
Congrats for this module. It is getting better and better.
I have mittered joint, and I wan't to increase gap. I am going to combo view section Parameteres Ex and do extend1 to -1 and extednd2 to -2 and gap increase but bend stays as not moved. Is there any option to operate with bend? Or this is a bug and should be changed in the future. Also after mittering stays some trash between bends - should I remove that with a pocket or it is possible to improve that later?
Pic below: Edit: because of that trashes sheet metal cannot unfold
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
added a fix for above problem
https://github.com/shaise/FreeCAD_SheetMetal/pull/59
https://github.com/shaise/FreeCAD_SheetMetal/pull/59
Re: help on sheet metal script
Wow it was fast. It changed a bit but not 100%. See attached file. The triangle stays, and also should be somehow better management of gaps - when selecting two edges and do the mittered joint, actually you have 3 (when midlle is symmetric) to 4 gaps (non symmetric) - when 3 edges you have 4 to 6 gaps. Is it possible to remove somehow that triangles?jaisejames wrote: ↑Thu Mar 14, 2019 8:43 am added a fix for above problem
https://github.com/shaise/FreeCAD_SheetMetal/pull/59
- Attachments
-
- sheet_metal_test.FCStd
- (26.39 KiB) Downloaded 51 times
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
Can you do "Mark to recompute" on bend & do a recompute.
Any other problem, if able to attach a file. I will be able check it.Re: help on sheet metal script
I done this but nothing changes. On your picture it looks super clean. File was attached above. I've updated sheet workbench also.
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
While fixing bug some new bug introduced. new fix is below.
https://github.com/shaise/FreeCAD_SheetMetal/pull/60
https://github.com/shaise/FreeCAD_SheetMetal/pull/60
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am